Bug 233617 - [WebXR] Implement ChromeClient API to allow getting explicit consent from user on session features
Summary: [WebXR] Implement ChromeClient API to allow getting explicit consent from use...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-29 21:14 PST by Ada Chan
Modified: 2021-11-30 12:42 PST (History)
4 users (show)

See Also:

Attachments
Patch (35.26 KB, patch)
2021-11-29 21:43 PST, Ada Chan 		dino: review+
Details | Formatted Diff | Diff
Patch for landing (35.31 KB, patch)
2021-11-30 11:14 PST, Ada Chan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2021-11-29 21:14:26 PST 
[WebXR] Implement ChromeClient API to allow getting explicit consent from user on session features
Comment 1 Ada Chan 2021-11-29 21:43:39 PST 
Created attachment 445380 [details]
Patch
Comment 2 Sergio Villar Senin 2021-11-30 02:11:18 PST 
Comment on attachment 445380 [details]
Patch

The WebXR spec requires us to use the Permissions API https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned at some point that there was interest in implementing the Permissions API.

Here you're using an ad-hoc solution via ChromeClient that should be replaced at some point by the permissions API variant.
Comment 3 Ada Chan 2021-11-30 08:45:15 PST 
(In reply to Sergio Villar Senin from comment #2)
> Comment on attachment 445380 [details]
> Patch
> 
> The WebXR spec requires us to use the Permissions API
> https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned
> at some point that there was interest in implementing the Permissions API.
> 
> Here you're using an ad-hoc solution via ChromeClient that should be
> replaced at some point by the permissions API variant.

I'll add a FIXME about replacing that with the Permissions API.
Comment 4 Dean Jackson 2021-11-30 10:49:51 PST 
(In reply to Sergio Villar Senin from comment #2)
> Comment on attachment 445380 [details]
> Patch
> 
> The WebXR spec requires us to use the Permissions API
> https://immersive-web.github.io/webxr/#permissions. I think Maciej mentioned
> at some point that there was interest in implementing the Permissions API.
> 
> Here you're using an ad-hoc solution via ChromeClient that should be
> replaced at some point by the permissions API variant.

Yeah, we'll use this until we implement Permissions.
Comment 5 Ada Chan 2021-11-30 11:14:26 PST 
Created attachment 445446 [details]
Patch for landing
Comment 6 EWS 2021-11-30 12:41:53 PST 
Committed r286318 (244677@main): <https://commits.webkit.org/244677@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445446 [details].
Comment 7 Radar WebKit Bug Importer 2021-11-30 12:42:25 PST 
<rdar://problem/85881840>