Bug 233604 - Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks
Summary: Several WPT tests under html/semantics/forms/constraints are failing due to e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 233428
  Show dependency tree / graph
 
Reported: 2021-11-29 15:52 PST by Chris Dumez
Modified: 2021-11-30 15:08 PST (History)
13 users (show)

See Also:

Attachments
Patch (37.13 KB, patch)
2021-11-29 15:54 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (42.24 KB, patch)
2021-11-29 18:44 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (66.44 KB, patch)
2021-11-30 07:34 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (66.46 KB, patch)
2021-11-30 10:06 PST, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-29 15:52:07 PST 
Several WPT tests under html/semantics/forms/constraints are failing due to extraneous willValidate() checks. Per the specification and to match the behavior of Blink & Gecko, ValidityState properties such as validity.typeMismatch should return true in case of mismatch even if the control is disabled (and thus willValidate() returns false).
Comment 1 Chris Dumez 2021-11-29 15:54:56 PST 
Created attachment 445359 [details]
Patch
Comment 2 Chris Dumez 2021-11-29 18:44:01 PST 
Created attachment 445371 [details]
Patch
Comment 3 Chris Dumez 2021-11-30 07:34:27 PST 
Created attachment 445415 [details]
Patch
Comment 4 Chris Dumez 2021-11-30 10:06:39 PST 
Created attachment 445432 [details]
Patch
Comment 5 EWS 2021-11-30 12:39:15 PST 
Committed r286316 (244675@main): <https://commits.webkit.org/244675@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445432 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-30 12:40:22 PST 
<rdar://problem/85881653>
Comment 7 Darin Adler 2021-11-30 12:51:34 PST 
Noticed the misspelling "undeflow" is fairly common here.
Comment 8 Chris Dumez 2021-11-30 12:58:12 PST 
(In reply to Darin Adler from comment #7)
> Noticed the misspelling "undeflow" is fairly common here.

Fixed in <https://commits.webkit.org/r286319>, thanks for noticing.