Bug 233603 - AX: Reduce repetition in retrieving typed attribute values in AccessibilityUIElementMac
Summary: AX: Reduce repetition in retrieving typed attribute values in AccessibilityUI...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
Keywords: InRadar
Depends on:
Reported: 2021-11-29 15:45 PST by Tyler Wilcock
Modified: 2021-11-30 08:20 PST (History)
3 users (show)

See Also:

Patch (28.58 KB, patch)
2021-11-29 15:51 PST, Tyler Wilcock
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2021-11-29 15:45:56 PST
We have a lot of functions in both the WebKitTestRunner and DumpRenderTree versions of AccessibilityUIElementMac that repeat the same logic for getting a typed attribute value. For example:

bool AccessibilityUIElement::hasPopup() const
    id value = [m_element accessibilityAttributeValue:@"AXHasPopup"];
    if ([value isKindOfClass:[NSNumber class]])
        return [value boolValue];

    return false;
Comment 1 Radar WebKit Bug Importer 2021-11-29 15:46:22 PST
Comment 2 Tyler Wilcock 2021-11-29 15:51:24 PST
Created attachment 445358 [details]
Comment 3 EWS 2021-11-30 07:13:44 PST
tyler_w@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 445358 [details] from commit queue.
Comment 4 EWS 2021-11-30 08:20:10 PST
Committed r286298 (244657@main): <https://commits.webkit.org/244657@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445358 [details].