Bug 233602 - Correct serialization error in _WKApplicationManifestIcon
Summary: Correct serialization error in _WKApplicationManifestIcon
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 233350
Blocks:
  Show dependency tree / graph
 
Reported: 2021-11-29 15:42 PST by Brent Fulgham
Modified: 2021-12-01 11:20 PST (History)
3 users (show)

See Also:

Attachments
Patch (5.48 KB, patch)
2021-11-30 09:26 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (5.47 KB, patch)
2021-11-30 10:45 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-11-29 15:42:37 PST 
In Bug 233350 I mistakenly set the NSSecureCoding classes for _WKApplicationManifestIcon's "purposes" property as an array of strings. However, this should be treated as an array of numbers.
Comment 1 Radar WebKit Bug Importer 2021-11-29 15:43:10 PST 
<rdar://problem/85838843>
Comment 2 Brent Fulgham 2021-11-30 09:09:07 PST 
To make matters worse, I was using an NSString to decode an NSURL, which obviously didn't work.

I've added a test case to exercise this code.
Comment 3 Brent Fulgham 2021-11-30 09:26:14 PST 
Created attachment 445427 [details]
Patch
Comment 4 Devin Rousso 2021-11-30 10:27:42 PST 
Comment on attachment 445427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445427&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:379
> +    EXPECT_FALSE(error);

NIT: `EXPECT_NULL`?

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:382
> +    EXPECT_FALSE(error);

ditto (:379)
Comment 5 Brent Fulgham 2021-11-30 10:42:27 PST 
Comment on attachment 445427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445427&action=review

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:379
>> +    EXPECT_FALSE(error);
> 
> NIT: `EXPECT_NULL`?

Ah! Will do.

>> Tools/TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm:382
>> +    EXPECT_FALSE(error);
> 
> ditto (:379)

Ditto.
Comment 6 Brent Fulgham 2021-11-30 10:45:45 PST 
Created attachment 445441 [details]
Patch for landing
Comment 7 EWS 2021-11-30 11:52:36 PST 
Committed r286311 (244670@main): <https://commits.webkit.org/244670@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445441 [details].