Bug 233601 - html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing
Summary: html/semantics/forms/constraints/form-validation-validity-patternMismatch.htm...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 233428
  Show dependency treegraph
 
Reported: 2021-11-29 15:32 PST by Chris Dumez
Modified: 2021-11-30 12:39 PST (History)
13 users (show)

See Also:


Attachments
Patch (17.17 KB, patch)
2021-11-29 15:37 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.58 KB, patch)
2021-11-29 16:53 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.45 KB, patch)
2021-11-30 07:49 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.47 KB, patch)
2021-11-30 10:35 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-29 15:32:37 PST
html/semantics/forms/constraints/form-validation-validity-patternMismatch.html WPT test is failing in WebKit but passing in Blink & Gecko.
Comment 1 Chris Dumez 2021-11-29 15:37:28 PST
Created attachment 445355 [details]
Patch
Comment 2 Chris Dumez 2021-11-29 16:53:00 PST
Created attachment 445365 [details]
Patch
Comment 3 Chris Dumez 2021-11-30 07:49:08 PST
Created attachment 445417 [details]
Patch
Comment 4 Darin Adler 2021-11-30 09:12:31 PST
Comment on attachment 445417 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445417&action=review

> Source/WebCore/html/BaseTextInputType.cpp:46
> +    String pattern = makeString("^(?:", rawPattern, ")$");

I’d think we’d want to create and capture a single Yarr::RegularExpression and re-use it to make the findMatching loop more efficient.
Comment 5 Chris Dumez 2021-11-30 10:35:34 PST
Created attachment 445437 [details]
Patch
Comment 6 EWS 2021-11-30 12:38:34 PST
Committed r286315 (244674@main): <https://commits.webkit.org/244674@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445437 [details].
Comment 7 Radar WebKit Bug Importer 2021-11-30 12:39:23 PST
<rdar://problem/85881537>