Bug 23360 – Make repainting compositing-aware for accelerated compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

This bug trackes changes to the repainting code that are required for accelerated compositing.

[Simon Fraser (smfr)]

Created attachment 27067 [details]
Patch to create container-relative repaint methods

This is phase 1: add variants of the various "absolute repaint" methods that take a RenderBox container, and compute the repaint rect relative to that. For now, RenderObject::containerForRepaint() always returns 0, so all repaints are still root-relative.

[Dave Hyatt]

Comment on attachment 27067 [details]
Patch to create container-relative repaint methods

r=me

We've got to rename these methods to something better though.

[Simon Fraser (smfr)]

Filed bug 23565 on renaming.

[Simon Fraser (smfr)]

Comment on attachment 27067 [details]
Patch to create container-relative repaint methods

Committed in http://trac.webkit.org/changeset/40288

[Simon Fraser (smfr)]

Created attachment 27069 [details]
Phase 2 patch: use the new container-relative repaint rects.

[Simon Fraser (smfr)]

Created attachment 27077 [details]
Phase 2 patch: use the new container-relative repaint rects.

[Simon Fraser (smfr)]

Comment on attachment 27077 [details]
Phase 2 patch: use the new container-relative repaint rects.

Will re-do this patch after another change.

[Simon Fraser (smfr)]

Created attachment 27086 [details]
Patch to put the repaintContainer argument first in computeRectForRepaint()

[Dave Hyatt]

Comment on attachment 27086 [details]
Patch to put the repaintContainer argument first in computeRectForRepaint()

r=me

[Simon Fraser (smfr)]

Comment on attachment 27086 [details]
Patch to put the repaintContainer argument first in computeRectForRepaint()

Committed:

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderBox.cpp
	M	WebCore/rendering/RenderBox.h
	M	WebCore/rendering/RenderForeignObject.cpp
	M	WebCore/rendering/RenderForeignObject.h
	M	WebCore/rendering/RenderInline.cpp
	M	WebCore/rendering/RenderObject.cpp
	M	WebCore/rendering/RenderObject.h
	M	WebCore/rendering/RenderReplaced.cpp
	M	WebCore/rendering/RenderTableCell.cpp
	M	WebCore/rendering/RenderTableCell.h
	M	WebCore/rendering/RenderView.cpp
	M	WebCore/rendering/RenderView.h
Committed r40300

[Simon Fraser (smfr)]

Created attachment 27087 [details]
Phase 3 patch: use container-relative repaint during layout.

[Dave Hyatt]

Comment on attachment 27087 [details]
Phase 3 patch: use container-relative repaint during layout.

r=me.  Please rename repaintViaContainer to repaintUsingContainer. I think "Via" is just awkward in a method name.

[Simon Fraser (smfr)]

Comment on attachment 27087 [details]
Phase 3 patch: use container-relative repaint during layout.

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderFlexibleBox.cpp
	M	WebCore/rendering/RenderForeignObject.cpp
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/RenderLayer.h
	M	WebCore/rendering/RenderObject.cpp
	M	WebCore/rendering/RenderObject.h
	M	WebCore/rendering/RenderPath.cpp
	M	WebCore/rendering/RenderReplaced.cpp
	M	WebCore/rendering/RenderSVGContainer.cpp
	M	WebCore/rendering/RenderSVGImage.cpp
	M	WebCore/rendering/RenderSVGRoot.cpp
	M	WebCore/rendering/RenderSVGText.cpp
	M	WebCore/rendering/RenderSVGViewportContainer.cpp
	M	WebCore/rendering/RenderTable.cpp
	M	WebCore/rendering/bidi.cpp
Committed r40303

[Simon Fraser (smfr)]

Created attachment 27193 [details]
Patch to use container-relative methods for computing repaints before layout

[Dave Hyatt]

Comment on attachment 27193 [details]
Patch to use container-relative methods for computing repaints before layout

r=me

[Simon Fraser (smfr)]

Comment on attachment 27193 [details]
Patch to use container-relative methods for computing repaints before layout

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderObject.h

[Simon Fraser (smfr)]

Created attachment 27268 [details]
Final repaint patch: hook up to composited layers.

[Dave Hyatt]

Comment on attachment 27268 [details]
Final repaint patch: hook up to composited layers.

Put a FIXME in RenderInline, since you aren't really dealing with the problem yet.

You really shouldn't get a null containingBlock() ever from within containingBlockWith()/Height().  I do approve of nuking a useless FIXME though. :)

I think it's ok to have an enclosingCompositingLayer on RenderObject itself.  That will make the code cleaner in RenderObject::containerForRepaint.

OwnPtr please for RenderView::m_compositor.

updateRootLayerPosition should not be in updateWidgetPositions.  I would suggest updateLayerPositions or updateLayerPosition for the root layer, or perhaps you meant to do it post-layout (either where updateLayerPositions is or in performPostLayoutTasks).

I think you could just fix selection by adding enough info to get back to the repaint container to SelectionInfo objects, and then you wouldn't need the special view method.

Caret painting could also cache the repaint container that it needs to use.

[Simon Fraser (smfr)]

Created attachment 27333 [details]
Updated patch, changelog

[Dave Hyatt]

Comment on attachment 27333 [details]
Updated patch, changelog

r=me

[Simon Fraser (smfr)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/editing/SelectionController.cpp
	M	WebCore/rendering/RenderInline.cpp
	M	WebCore/rendering/RenderLayer.cpp
	M	WebCore/rendering/RenderLayer.h
	M	WebCore/rendering/RenderLayerBacking.cpp
	M	WebCore/rendering/RenderLayerCompositor.cpp
	M	WebCore/rendering/RenderLayerCompositor.h
	M	WebCore/rendering/RenderObject.cpp
	M	WebCore/rendering/RenderObject.h
	M	WebCore/rendering/RenderView.cpp
	M	WebCore/rendering/RenderView.h
	M	WebCore/rendering/RenderWidget.cpp
Committed r40640

Repaint work is now complete.