Bug 233593 - [JSC] slice should be aware of TerminationException
Summary: [JSC] slice should be aware of TerminationException
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
Keywords: InRadar
Depends on:
Reported: 2021-11-29 13:19 PST by Yusuke Suzuki
Modified: 2021-11-29 17:21 PST (History)
7 users (show)

See Also:

Patch (6.17 KB, patch)
2021-11-29 13:20 PST, Yusuke Suzuki
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-11-29 13:19:57 PST
[JSC] slice should be aware of terminated excution exception
Comment 1 Yusuke Suzuki 2021-11-29 13:20:37 PST
Created attachment 445332 [details]
Comment 2 Yusuke Suzuki 2021-11-29 13:20:42 PST
Comment 3 Mark Lam 2021-11-29 13:29:31 PST
Comment on attachment 445332 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=445332&action=review


> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] slice should be aware of terminated excution exception

It’s called a TerminationException now.  Also, you had a typo in “excution”.

> Source/JavaScriptCore/ChangeLog:9
> +        Since terminated execution exception can happen at any time, assertNoException is wrong.

Ditto.  Please use “termination exception” instead.

> JSTests/ChangeLog:9
> +        * stress/slice-terminated-execution-exception.js: Added.

I suggest renaming this to slice-termination-exception.js to match the new naming.
Comment 4 Yusuke Suzuki 2021-11-29 17:21:04 PST
Committed r286275 (244636@main): <https://commits.webkit.org/244636@main>