Bug 233583 - Plumb raw platform scrolling deltas along in wheel events
Summary: Plumb raw platform scrolling deltas along in wheel events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-29 11:58 PST by Tim Horton
Modified: 2021-11-29 18:56 PST (History)
2 users (show)

See Also:


Attachments
Patch (13.37 KB, patch)
2021-11-29 12:01 PST, Tim Horton
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.17 KB, patch)
2021-11-29 13:47 PST, Tim Horton
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (14.42 KB, patch)
2021-11-29 14:31 PST, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (14.33 KB, patch)
2021-11-29 14:32 PST, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-11-29 11:58:54 PST
Plumb raw platform scrolling deltas along in wheel events
Comment 1 Tim Horton 2021-11-29 12:01:03 PST
Created attachment 445319 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-11-29 12:03:38 PST
Comment on attachment 445319 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445319&action=review

> Source/WebKit/Shared/mac/WebEventFactory.mm:436
> +        return { WebCore::FloatSize(-IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollX), -IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollY)) };

Does the negation here mean that m_rawPlatformDelta has the same sign as scrollingDelta?
Comment 3 Tim Horton 2021-11-29 12:16:27 PST
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 445319 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=445319&action=review
> 
> > Source/WebKit/Shared/mac/WebEventFactory.mm:436
> > +        return { WebCore::FloatSize(-IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollX), -IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollY)) };
> 
> Does the negation here mean that m_rawPlatformDelta has the same sign as
> scrollingDelta?

That was the idea, but let me double check that I got that right, so many things are in opposing signs :)
Comment 4 Tim Horton 2021-11-29 13:47:23 PST
Created attachment 445337 [details]
Patch
Comment 5 Tim Horton 2021-11-29 14:31:52 PST
Created attachment 445346 [details]
Patch
Comment 6 Tim Horton 2021-11-29 14:32:43 PST
Created attachment 445347 [details]
Patch
Comment 7 Tim Horton 2021-11-29 15:27:59 PST
(In reply to Tim Horton from comment #3)
> (In reply to Simon Fraser (smfr) from comment #2)
> > Comment on attachment 445319 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=445319&action=review
> > 
> > > Source/WebKit/Shared/mac/WebEventFactory.mm:436
> > > +        return { WebCore::FloatSize(-IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollX), -IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollY)) };
> > 
> > Does the negation here mean that m_rawPlatformDelta has the same sign as
> > scrollingDelta?
> 
> That was the idea, but let me double check that I got that right, so many
> things are in opposing signs :)

yes, that is the outcome
Comment 8 EWS 2021-11-29 15:58:40 PST
Committed r286270 (244631@main): <https://commits.webkit.org/244631@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445347 [details].
Comment 9 Radar WebKit Bug Importer 2021-11-29 15:59:24 PST
<rdar://problem/85839550>
Comment 10 Tim Horton 2021-11-29 18:56:30 PST
Build fix: https://trac.webkit.org/changeset/286277/webkit