Plumb raw platform scrolling deltas along in wheel events
Created attachment 445319 [details] Patch
Comment on attachment 445319 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445319&action=review > Source/WebKit/Shared/mac/WebEventFactory.mm:436 > + return { WebCore::FloatSize(-IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollX), -IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollY)) }; Does the negation here mean that m_rawPlatformDelta has the same sign as scrollingDelta?
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 445319 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445319&action=review > > > Source/WebKit/Shared/mac/WebEventFactory.mm:436 > > + return { WebCore::FloatSize(-IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollX), -IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollY)) }; > > Does the negation here mean that m_rawPlatformDelta has the same sign as > scrollingDelta? That was the idea, but let me double check that I got that right, so many things are in opposing signs :)
Created attachment 445337 [details] Patch
Created attachment 445346 [details] Patch
Created attachment 445347 [details] Patch
(In reply to Tim Horton from comment #3) > (In reply to Simon Fraser (smfr) from comment #2) > > Comment on attachment 445319 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=445319&action=review > > > > > Source/WebKit/Shared/mac/WebEventFactory.mm:436 > > > + return { WebCore::FloatSize(-IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollX), -IOHIDEventGetFloatValue(ioHIDEvent.get(), kIOHIDEventFieldScrollY)) }; > > > > Does the negation here mean that m_rawPlatformDelta has the same sign as > > scrollingDelta? > > That was the idea, but let me double check that I got that right, so many > things are in opposing signs :) yes, that is the outcome
Committed r286270 (244631@main): <https://commits.webkit.org/244631@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445347 [details].
<rdar://problem/85839550>
Build fix: https://trac.webkit.org/changeset/286277/webkit