Playstation build is broken after r286171 due to conflict with function override. https://build.webkit.org/#/builders/65/builds/9628/steps/8/logs/stdio ../../Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:63:25: error: call to non-static member function without an object argument while ((bytesRead = read(fd, buffer.data() + totalBytesRead, bytesToRead - totalBytesRead)) > 0)
Created attachment 445338 [details] Patch
Comment on attachment 445338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445338&action=review > Source/WebCore/platform/posix/SharedBufferPOSIX.cpp:63 > + while ((bytesRead = FileSystem::readFromFile(fd, buffer.data() + totalBytesRead, bytesToRead - totalBytesRead)) > 0) If the intention is to fix the build, why don't we just use ::read()?
Created attachment 445435 [details] Patch
Created attachment 445438 [details] Patch
ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.
Created attachment 445457 [details] New patch fixed style.
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Created attachment 445478 [details] Patch for build fix. changed reviewer from nobody to unreviewed.
Created attachment 445479 [details] [fast-cq] patch for build fix
Committed r286330 (244689@main): <https://commits.webkit.org/244689@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445479 [details].
<rdar://problem/85892745>