Bug 233572 – Web Inspector: Computed Panel: Properties section should be hidden when the filter doesn't match

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Inspector

[Razvan Caliman]

Created attachment 445292 [details]
Properties section header should be hidden

When using the filter input field in the Computed panel, the Properties section header remains visible if there are no matches for the filter query. 
Variables section header is hidden as expected. 
See attached screenshot.

[Radar WebKit Bug Importer]

<rdar://problem/85822886>

[Razvan Caliman]

Created attachment 445295 [details]
Patch 1.0

Fix bug by bringing `WI.ComputedStyleSection.applyFilter()` to parity with
        `WI.SpreadsheetCSSStyleDeclarationEditor.applyFilter()`

[Razvan Caliman]

Created attachment 445297 [details]
Computed panel with patch applied

Properties and Variables section headers are hidden when there are no matches for the given filter input.

[Patrick Angle]

Comment on attachment 445295 [details]
Patch 1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=445295&action=review

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:247
> +                if (this._hideFilterNonMatchingProperties)
> +                    this.element.append(propertyView.element);

This doesn't seem correct to me... Couldn't this cause property views to be out of order if they were previously filtered out but now aren't? The `this.needsLayout()` will undo this work anyways since `layout()` removes all the elements and re-adds them in the correct order.

> Source/WebInspectorUI/UserInterface/Views/ComputedStyleSection.js:255
> +        this.dispatchEventToListeners(WI.ComputedStyleSection.Event.FilterApplied, {matches});

Could we instead just fire this event inside `layout()`with a `matches` determined during `layout()` instead and leave this function as-is?

[Razvan Caliman]

Fixed as part of Bug 242704

*** This bug has been marked as a duplicate of bug 242704 ***