Bug 233562 - [css-writing-modes] Use the correct margins in computeInlinePreferredLogicalWidths in orthogonal flows
Summary: [css-writing-modes] Use the correct margins in computeInlinePreferredLogicalW...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-29 08:52 PST by Sergio Villar Senin
Modified: 2021-12-13 09:20 PST (History)
20 users (show)

See Also:

Attachments
Patch (3.42 KB, patch)
2021-11-29 08:52 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (4.11 KB, patch)
2021-11-29 09:03 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (7.69 KB, patch)
2021-12-13 07:01 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Patch (7.69 KB, patch)
2021-12-13 07:22 PST, Sergio Villar Senin 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2021-11-29 08:52:09 PST 
[css-writing-modes] Use the correct margins in computeInlinePreferredLogicalWidths in orthogonal flows
Comment 1 Sergio Villar Senin 2021-11-29 08:52:47 PST 
Created attachment 445282 [details]
Patch
Comment 2 Sergio Villar Senin 2021-11-29 09:03:33 PST 
Created attachment 445283 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2021-12-06 08:53:23 PST 
<rdar://problem/86105904>
Comment 4 Sergio Villar Senin 2021-12-07 00:57:42 PST 
Ping reviewers
Comment 5 Manuel Rego Casasnovas 2021-12-07 03:00:41 PST 
Comment on attachment 445283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445283&action=review

LGTM.

> LayoutTests/TestExpectations:-4245
> -# The test works fine but the expected result fails due to a missing layout.

It looks like we're fixing the reference but not the test itself.

Could we add a new test (maybe unrelated to flexbox) that fails now and will pass with this patch?
Comment 6 Sergio Villar Senin 2021-12-08 00:53:19 PST 
(In reply to Manuel Rego Casasnovas from comment #5)
> Comment on attachment 445283 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=445283&action=review
> 
> LGTM.
> 
> > LayoutTests/TestExpectations:-4245
> > -# The test works fine but the expected result fails due to a missing layout.
> 
> It looks like we're fixing the reference but not the test itself.
> 
> Could we add a new test (maybe unrelated to flexbox) that fails now and will
> pass with this patch?

Right. This is not a flexbox issue but an issue of how we handle margins in orthogonal flows with inline elements. I guess I could add some WPT test to css/css-writing-modes...
Comment 7 Sergio Villar Senin 2021-12-13 07:01:06 PST 
Created attachment 447001 [details]
Patch
Comment 8 EWS Watchlist 2021-12-13 07:02:16 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 9 Sergio Villar Senin 2021-12-13 07:22:00 PST 
Created attachment 447002 [details]
Patch
Comment 10 EWS 2021-12-13 09:20:39 PST 
Committed r286952 (245177@main): <https://commits.webkit.org/245177@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447002 [details].