WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
233556
Console Timing API does not contain space before duration when it gets printed
https://bugs.webkit.org/show_bug.cgi?id=233556
Summary
Console Timing API does not contain space before duration when it gets printed
Max Schmitt
Reported
2021-11-29 06:01:22 PST
```js console.time("MyTimer"); console.timeLog("MyTimer"); ``` Expected: ``` MyTimer: 0.018 ms ``` Actual: ``` MyTimer: 0.018ms ``` There should be a space between the duration and the unit, see here in the spec:
https://console.spec.whatwg.org/#timelog
Attachments
Patch
(4.30 KB, patch)
2021-11-30 07:35 PST
,
Youssef Soliman
hi
: review-
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Youssef Soliman
Comment 1
2021-11-30 07:35:05 PST
Created
attachment 445416
[details]
Patch
Devin Rousso
Comment 2
2021-11-30 10:35:34 PST
(In reply to Max Schmitt from
comment #0
)
> There should be a space between the duration and the unit, see here in the spec:
https://console.spec.whatwg.org/#timelog
I dont think this is correct. The exact wording is
> Let _duration_ be a string representing the difference between the current time and _startTime_, in an implementation-defined format.
The only space that's required is between the `:` and the _duration_, which we already have. The example includes spaces, but that's just an example not required output.
Youssef Soliman
Comment 3
2021-11-30 10:47:43 PST
(In reply to Devin Rousso from
comment #2
)
> (In reply to Max Schmitt from
comment #0
) > > There should be a space between the duration and the unit, see here in the spec:
https://console.spec.whatwg.org/#timelog
> > I dont think this is correct. The exact wording is > > > Let _duration_ be a string representing the difference between the current time and _startTime_, in an implementation-defined format. > > The only space that's required is between the `:` and the _duration_, which > we already have. The example includes spaces, but that's just an example > not required output.
Thanks, Devin, the spec never explicitly mentions a space between the value and unit in _duration_. For example, in the latest Node.js release, the output is `MyTimer: 0.018ms`.
Devin Rousso
Comment 4
2021-11-30 10:50:11 PST
Comment on
attachment 445416
[details]
Patch Our normal style in Web Inspector is to not have a space between the value and unit, so unless there's some compelling reason to do this I don't think we should break from our usual style.
Radar WebKit Bug Importer
Comment 5
2021-12-06 06:02:20 PST
<
rdar://problem/86100703
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug