Bug 233528 - [MSE] Fix erase range to prevent accidental deletion in files with changing durations
Summary: [MSE] Fix erase range to prevent accidental deletion in files with changing d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-11-26 12:53 PST by Alicia Boya García
Modified: 2021-12-03 00:25 PST (History)
8 users (show)

See Also:

Attachments
Patch (8.00 KB, patch)
2021-11-26 12:57 PST, Alicia Boya García 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alicia Boya García 2021-11-26 12:53:33 PST 
In didReceiveSample(), eraseBeginTime was being set to
highestPresentationTimestamp minus a tolerance. The tolerance is not
needed since highestPresentationTimestamp is loaded from exact frame
timestamps, and can cause accidental frame erasure in situations where
there are frames with frames smaller than the tolerance, which is the
case for certain MP4 files.

Test: media/media-source/media-source-append-tiny-durations.html
Comment 1 Alicia Boya García 2021-11-26 12:57:02 PST 
Created attachment 445208 [details]
Patch
Comment 2 EWS 2021-12-03 00:25:24 PST 
Committed r286485 (244824@main): <https://commits.webkit.org/244824@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445208 [details].