RESOLVED DUPLICATE of bug 233513 Bug 233512
GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code 
https://bugs.webkit.org/show_bug.cgi?id=233512
Summary GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platf...
Kimmo Kinnunen
Reported 2021-11-25 23:16:05 PST
GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code This blocks the task of removing ifdefs from GraphicsContextGLOpenGL.h by means of separating various code paths to separate classes. GraphicsContextGLOpenGL.cpp should contain only "OpenGL" specific code. Currently that code lives in GraphicsContextGLOpenGLCommon.cpp, so GraphicsContextGLOpenGL.cpp should be made empty and then ultimately GraphicsContextGLOpenGLCommon.cpp would be renamed to GraphicsContextGLOpenGL.cpp ANGLE specific code should go into GraphicsContextGLANGLE.cpp Platform specific code should go into platform specific files such as GraphicsContextGLCocoa.cpp and compositor specific files such as GraphicsContextGLTextureMapper.cpp.
Attachments
Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-11-26 06:36:13 PST
*** This bug has been marked as a duplicate of bug 233513 ***
Note You need to log in before you can comment on or make changes to this bug.