Bug 233512 - GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code
Summary: GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platf...
Status: RESOLVED DUPLICATE of bug 233513
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: gcgranglecleanup
  Show dependency tree / graph
 
Reported: 2021-11-25 23:16 PST by Kimmo Kinnunen
Modified: 2021-11-26 06:36 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-11-25 23:16:05 PST 
GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code

This blocks the task of removing ifdefs from GraphicsContextGLOpenGL.h by means of separating various code paths to separate classes.

GraphicsContextGLOpenGL.cpp should contain only "OpenGL" specific code. Currently that code lives in GraphicsContextGLOpenGLCommon.cpp, so GraphicsContextGLOpenGL.cpp should be made empty and then ultimately GraphicsContextGLOpenGLCommon.cpp would be renamed to GraphicsContextGLOpenGL.cpp

ANGLE specific code should go into GraphicsContextGLANGLE.cpp

Platform specific code should go into platform specific files such as GraphicsContextGLCocoa.cpp and compositor specific files such as GraphicsContextGLTextureMapper.cpp.
Comment 1 Kimmo Kinnunen 2021-11-26 06:36:13 PST 

*** This bug has been marked as a duplicate of bug 233513 ***