WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 23347
23350
Build failure because of missing include in wtf/ThreadingPthreads.cpp
https://bugs.webkit.org/show_bug.cgi?id=23350
Summary
Build failure because of missing include in wtf/ThreadingPthreads.cpp
Gustavo Noronha (kov)
Reported
2009-01-15 09:11:49 PST
Revision 39908 adds usage of INT_MAX and other limits to threading implementations, but missed the limits.h include for the pthreads implementation.
Attachments
proposed fix
(1.32 KB, patch)
2009-01-15 09:14 PST
,
Gustavo Noronha (kov)
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1
2009-01-15 09:14:02 PST
Created
attachment 26760
[details]
proposed fix
Brent Fulgham
Comment 2
2009-01-15 10:01:51 PST
> #include <errno.h> > #include <sys/time.h> > +#include <limits.h>
We generally put the includes in ASCII order.
Darin Adler
Comment 3
2009-01-15 10:29:28 PST
*** This bug has been marked as a duplicate of
23347
***
Darin Adler
Comment 4
2009-01-15 10:29:57 PST
Comment on
attachment 26760
[details]
proposed fix Patch is fine, but there's already a reviewed patch in the other bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug