Bug 23350 - Build failure because of missing include in wtf/ThreadingPthreads.cpp
Summary: Build failure because of missing include in wtf/ThreadingPthreads.cpp
Status: RESOLVED DUPLICATE of bug 23347
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Gustavo Noronha (kov)
Depends on:
Reported: 2009-01-15 09:11 PST by Gustavo Noronha (kov)
Modified: 2009-01-15 10:29 PST (History)
0 users

See Also:

proposed fix (1.32 KB, patch)
2009-01-15 09:14 PST, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2009-01-15 09:11:49 PST
Revision 39908 adds usage of INT_MAX and other limits to threading implementations, but missed the limits.h include for the pthreads implementation.
Comment 1 Gustavo Noronha (kov) 2009-01-15 09:14:02 PST
Created attachment 26760 [details]
proposed fix
Comment 2 Brent Fulgham 2009-01-15 10:01:51 PST
>  #include <errno.h>
>  #include <sys/time.h>
> +#include <limits.h>

We generally put the includes in ASCII order.
Comment 3 Darin Adler 2009-01-15 10:29:28 PST

*** This bug has been marked as a duplicate of 23347 ***
Comment 4 Darin Adler 2009-01-15 10:29:57 PST
Comment on attachment 26760 [details]
proposed fix

Patch is fine, but there's already a reviewed patch in the other bug.