Bug 233492 – [GStreamer][WPE] Control on-disk multimedia buffering via the WPE_SHELL_DISABLE_MEDIA_DISK_CACHE environment variable

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Enrique Ocaña]

Embedded platforms often don't have a persistent storage suitable for repetitive writes (eg: caching media files may wear out a flash drive, and RAM memory is scarce enough to use a tmpfs for caching).

Those platforms need a way to disable on-disk caching. Metrological has been successfully using an environment variable for that purpose downstream since 2016. If that implementation is upstreamed, other WPE users can benefit from it.

[Enrique Ocaña]

Created attachment 445136 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 445136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445136&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2565
> +    static bool computed = false;

Please, use std::once...

[Enrique Ocaña]

Comment on attachment 445136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445136&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2565
>> +    static bool computed = false;
> 
> Please, use std::once...

I've ended up using std::once_flag and std::call_once. They're very useful and I didn't know about them. Thanks!

[Enrique Ocaña]

Created attachment 445207 [details]
Patch

[EWS]

Committed r286210 (244592@main): <https://commits.webkit.org/244592@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445207 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85814319>