Bug 233454 – Make webpushd "fake registration for testing" much more complicated by adding a "mock app bundle" install

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Brady Eidson]

Make webpushd "fake registration for testing" much more complicated by adding a "mock app bundle" install

This replaces the `m_inMemoryOriginStringsWithPermissionForTesting` with a much more complicated `MockAppBundleForTesting` and `MockAppBundleRegistry`.

The effect is the same, but it makes the next patch much easier to follow.

[Brady Eidson]

Created attachment 445104 [details]
EWS v1

[Brady Eidson]

Created attachment 445108 [details]
EWS v2

[Brady Eidson]

Created attachment 445112 [details]
EWS v3

[Brady Eidson]

Created attachment 445115 [details]
EWS v4

[Alex Christensen]

Comment on attachment 445115 [details]
EWS v4

View in context: https://bugs.webkit.org/attachment.cgi?id=445115&action=review

> Source/WebKit/webpushd/AppBundleRequest.h:55
> +    ClientConnection* m_connection;

Let's not store a raw pointer.  Can this be a WeakPtr?

> Source/WebKit/webpushd/MockAppBundleForTesting.mm:43
> +

extra space, could use =default;

> Source/WebKit/webpushd/PushAppBundle.h:34
> +enum class PushAppBundleExists {

: bool

> Source/WebKit/webpushd/PushAppBundle.h:39
> +enum class PushAppBundleCreationResult {

: bool

[Brady Eidson]

Created attachment 445303 [details]
PFL v1

[Brady Eidson]

Created attachment 445312 [details]
PFL v2

[EWS]

Committed r286273 (244634@main): <https://commits.webkit.org/244634@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445312 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85840549>