Bug 233454 - Make webpushd "fake registration for testing" much more complicated by adding a "mock app bundle" install
Summary: Make webpushd "fake registration for testing" much more complicated by adding...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-23 15:29 PST by Brady Eidson
Modified: 2021-11-29 16:22 PST (History)
3 users (show)

See Also:

Attachments
EWS v1 (49.32 KB, patch)
2021-11-24 12:20 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
EWS v2 (49.47 KB, patch)
2021-11-24 13:24 PST, Brady Eidson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS v3 (49.60 KB, patch)
2021-11-24 14:48 PST, Brady Eidson 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
EWS v4 (49.60 KB, patch)
2021-11-24 17:31 PST, Brady Eidson 		achristensen: review+
achristensen: commit-queue-
Details | Formatted Diff | Diff
PFL v1 (49.62 KB, patch)
2021-11-29 11:15 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
PFL v2 (50.79 KB, patch)
2021-11-29 11:41 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2021-11-23 15:29:39 PST 
Make webpushd "fake registration for testing" much more complicated by adding a "mock app bundle" install

This replaces the `m_inMemoryOriginStringsWithPermissionForTesting` with a much more complicated `MockAppBundleForTesting` and `MockAppBundleRegistry`.

The effect is the same, but it makes the next patch much easier to follow.
Comment 1 Brady Eidson 2021-11-24 12:20:41 PST 
Created attachment 445104 [details]
EWS v1
Comment 2 Brady Eidson 2021-11-24 13:24:01 PST 
Created attachment 445108 [details]
EWS v2
Comment 3 Brady Eidson 2021-11-24 14:48:02 PST 
Created attachment 445112 [details]
EWS v3
Comment 4 Brady Eidson 2021-11-24 17:31:30 PST 
Created attachment 445115 [details]
EWS v4
Comment 5 Alex Christensen 2021-11-29 10:12:10 PST 
Comment on attachment 445115 [details]
EWS v4

View in context: https://bugs.webkit.org/attachment.cgi?id=445115&action=review

> Source/WebKit/webpushd/AppBundleRequest.h:55
> +    ClientConnection* m_connection;

Let's not store a raw pointer.  Can this be a WeakPtr?

> Source/WebKit/webpushd/MockAppBundleForTesting.mm:43
> +

extra space, could use =default;

> Source/WebKit/webpushd/PushAppBundle.h:34
> +enum class PushAppBundleExists {

: bool

> Source/WebKit/webpushd/PushAppBundle.h:39
> +enum class PushAppBundleCreationResult {

: bool
Comment 6 Brady Eidson 2021-11-29 11:15:47 PST 
Created attachment 445303 [details]
PFL v1
Comment 7 Brady Eidson 2021-11-29 11:41:58 PST 
Created attachment 445312 [details]
PFL v2
Comment 8 EWS 2021-11-29 16:21:03 PST 
Committed r286273 (244634@main): <https://commits.webkit.org/244634@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445312 [details].
Comment 9 Radar WebKit Bug Importer 2021-11-29 16:22:21 PST 
<rdar://problem/85840549>