Bug 233452 - [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
Summary: [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords:
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2021-11-23 14:56 PST by Lauro Moura
Modified: 2021-11-23 19:47 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.62 KB, patch)
2021-11-23 14:57 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
Patch for landing (1.74 KB, patch)
2021-11-23 19:17 PST, Lauro Moura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-11-23 14:56:35 PST 
[GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
Comment 1 Lauro Moura 2021-11-23 14:57:32 PST 
Created attachment 445051 [details]
Patch
Comment 2 Michael Catanzaro 2021-11-23 15:50:47 PST 
Comment on attachment 445051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445051&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:1336
>      window->backgroundColor.alpha = 1;

Nit: might as well write this as 1.0 as well, to be consistent with the line above. Or write 1 in both places. Doesn't matter, of course....
Comment 3 Lauro Moura 2021-11-23 19:17:53 PST 
Created attachment 445058 [details]
Patch for landing
Comment 4 EWS 2021-11-23 19:47:13 PST 
Committed r286141 (244528@main): <https://commits.webkit.org/244528@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445058 [details].