WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23345
SharedBuffer.h should include wtf/OwnPtr.h
https://bugs.webkit.org/show_bug.cgi?id=23345
Summary
SharedBuffer.h should include wtf/OwnPtr.h
Darin Fisher (:fishd, Google)
Reported
2009-01-15 01:15:01 PST
SharedBuffer.h should include wtf/OwnPtr.h ... because it has an OwnPtr<T> member variable. As is, any .cpp file that includes SharedBuffer.h has to include OwnPtr.h. That seems undesirable. Patch coming up.
Attachments
v1 patch
(913 bytes, patch)
2009-01-15 01:16 PST
,
Darin Fisher (:fishd, Google)
no flags
Details
Formatted Diff
Diff
v2 patch
(968 bytes, patch)
2009-01-15 01:17 PST
,
Darin Fisher (:fishd, Google)
eric
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1
2009-01-15 01:16:13 PST
Created
attachment 26750
[details]
v1 patch
Darin Fisher (:fishd, Google)
Comment 2
2009-01-15 01:17:39 PST
Created
attachment 26751
[details]
v2 patch ... and sort the includes.
Eric Seidel (no email)
Comment 3
2009-01-15 01:19:37 PST
Comment on
attachment 26751
[details]
v2 patch LGTM.
Darin Fisher (:fishd, Google)
Comment 4
2009-01-15 01:28:14 PST
http://trac.webkit.org/changeset/39933
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug