Bug 23345 - SharedBuffer.h should include wtf/OwnPtr.h
Summary: SharedBuffer.h should include wtf/OwnPtr.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-15 01:15 PST by Darin Fisher (:fishd, Google)
Modified: 2009-01-15 01:28 PST (History)
0 users

See Also:

Attachments
v1 patch (913 bytes, patch)
2009-01-15 01:16 PST, Darin Fisher (:fishd, Google) 		no flags Details | Formatted Diff | Diff
v2 patch (968 bytes, patch)
2009-01-15 01:17 PST, Darin Fisher (:fishd, Google) 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-01-15 01:15:01 PST 
SharedBuffer.h should include wtf/OwnPtr.h

... because it has an OwnPtr<T> member variable.

As is, any .cpp file that includes SharedBuffer.h has to include OwnPtr.h.  That seems undesirable.

Patch coming up.
Comment 1 Darin Fisher (:fishd, Google) 2009-01-15 01:16:13 PST 
Created attachment 26750 [details]
v1 patch
Comment 2 Darin Fisher (:fishd, Google) 2009-01-15 01:17:39 PST 
Created attachment 26751 [details]
v2 patch

... and sort the includes.
Comment 3 Eric Seidel (no email) 2009-01-15 01:19:37 PST 
Comment on attachment 26751 [details]
v2 patch

LGTM.
Comment 4 Darin Fisher (:fishd, Google) 2009-01-15 01:28:14 PST 
http://trac.webkit.org/changeset/39933