Bug 233424 - [JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
Summary: [JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-22 07:28 PST by Geza Lore
Modified: 2021-11-30 07:44 PST (History)
9 users (show)

See Also:

Attachments
Patch (146.07 KB, patch)
2021-11-22 08:26 PST, Geza Lore 		no flags Details | Formatted Diff | Diff
Patch (145.10 KB, patch)
2021-11-22 09:51 PST, Geza Lore 		no flags Details | Formatted Diff | Diff
Patch (145.10 KB, patch)
2021-11-23 02:16 PST, Geza Lore 		no flags Details | Formatted Diff | Diff
Patch (145.10 KB, patch)
2021-11-24 05:51 PST, Geza Lore 		no flags Details | Formatted Diff | Diff
Fix nit (145.14 KB, patch)
2021-11-30 02:40 PST, Geza Lore 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geza Lore 2021-11-22 07:28:02 PST 
[JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
Comment 1 Geza Lore 2021-11-22 08:26:11 PST 
Created attachment 444968 [details]
Patch
Comment 2 Geza Lore 2021-11-22 09:51:49 PST 
Created attachment 444975 [details]
Patch
Comment 3 Geza Lore 2021-11-23 02:16:32 PST 
Created attachment 445019 [details]
Patch
Comment 4 Geza Lore 2021-11-24 05:51:29 PST 
Created attachment 445093 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-11-29 07:28:19 PST 
<rdar://problem/85815818>
Comment 6 Yusuke Suzuki 2021-11-29 13:00:43 PST 
Comment on attachment 445093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445093&action=review

r=me

> Source/JavaScriptCore/jit/JIT.h:336
> +        static inline constexpr bool is_profiled_op = std::is_same_v<decltype(Op::Metadata::m_profile), ValueProfile>;

Rename it to isProfiledOp.
Comment 7 Geza Lore 2021-11-30 02:40:48 PST 
Created attachment 445401 [details]
Fix nit
Comment 8 EWS 2021-11-30 07:44:33 PST 
Committed r286296 (244655@main): <https://commits.webkit.org/244655@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445401 [details].