Bug 233423 - [LFC][Integration] Remove dirOverride
Summary: [LFC][Integration] Remove dirOverride
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-22 07:26 PST by Antti Koivisto
Modified: 2021-11-22 10:14 PST (History)
17 users (show)

See Also:

Attachments
Patch (11.76 KB, patch)
2021-11-22 07:29 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (1.16 MB, patch)
2021-11-22 08:19 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch for landing (1.16 MB, patch)
2021-11-22 09:20 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2021-11-22 07:26:16 PST 
This legacy inline box bit is used to set directionOverride bit when creating a TextRun for the box. However that bit is never needed in cases these TextRuns are created for (painting and editing).

In practice it only affects render tree dumps and can be removed.
Comment 1 Antti Koivisto 2021-11-22 07:29:49 PST 
Created attachment 444965 [details]
Patch
Comment 2 Antti Koivisto 2021-11-22 08:19:51 PST 
Created attachment 444967 [details]
Patch
Comment 3 Antti Koivisto 2021-11-22 09:20:01 PST 
Created attachment 444972 [details]
Patch for landing
Comment 4 EWS 2021-11-22 10:13:17 PST 
Committed r286113 (244500@main): <https://commits.webkit.org/244500@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444972 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-22 10:14:21 PST 
<rdar://problem/85679362>