WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
233422
Allow AudioSampleDataSource to increase/decrease buffered data progressively
https://bugs.webkit.org/show_bug.cgi?id=233422
Summary
Allow AudioSampleDataSource to increase/decrease buffered data progressively
youenn fablet
Reported
2021-11-22 06:54:06 PST
Allow AudioSampleDataSource to increase/decrease buffered data
Attachments
Patch
(14.95 KB, patch)
2021-11-22 07:04 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(37.07 KB, patch)
2021-12-01 03:13 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Rebasing
(38.14 KB, patch)
2021-12-15 09:01 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Updated according review
(39.75 KB, patch)
2021-12-16 06:34 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Use > instead of == when comparing sample count
(39.80 KB, patch)
2021-12-16 08:01 PST
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2021-11-22 07:04:04 PST
Created
attachment 444964
[details]
Patch
Radar WebKit Bug Importer
Comment 2
2021-11-29 06:55:25 PST
<
rdar://problem/85814914
>
Eric Carlson
Comment 3
2021-11-29 08:45:50 PST
Comment on
attachment 444964
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=444964&action=review
r=me
> Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm:85 > + if (m_lowConverter) { > + PAL::AudioConverterDispose(m_lowConverter); > + m_lowConverter = nullptr; > + }
Nit: It might be worth creating a simple AudioConverter class to handle allocation, deallocation, and setup so you can cut down on the amount of boiler plate in the destructor and here.
youenn fablet
Comment 4
2021-12-01 03:13:02 PST
Created
attachment 445544
[details]
Patch
youenn fablet
Comment 5
2021-12-15 09:01:54 PST
Created
attachment 447239
[details]
Rebasing
Eric Carlson
Comment 6
2021-12-15 10:17:13 PST
Comment on
attachment 447239
[details]
Rebasing View in context:
https://bugs.webkit.org/attachment.cgi?id=447239&action=review
> Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm:87 > + return 0;
s/0/noErr/
> Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm:93 > + return 0;
Ditto
youenn fablet
Comment 7
2021-12-16 06:34:01 PST
Created
attachment 447351
[details]
Updated according review
youenn fablet
Comment 8
2021-12-16 08:01:42 PST
Created
attachment 447357
[details]
Use > instead of == when comparing sample count
EWS
Comment 9
2021-12-16 14:04:11 PST
Committed
r287157
(
245334@main
): <
https://commits.webkit.org/245334@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 447357
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug