Bug 233411 - Unused getEOTHeader method in OpenTypeUtilities.cpp
Summary: Unused getEOTHeader method in OpenTypeUtilities.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jean-Yves Avenard [:jya]
URL:
Keywords: InRadar
Depends on:
Blocks: 233030
  Show dependency tree / graph
 
Reported: 2021-11-21 21:17 PST by Jean-Yves Avenard [:jya]
Modified: 2021-11-22 12:35 PST (History)
5 users (show)

See Also:

Attachments
Patch (8.63 KB, patch)
2021-11-21 21:21 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Patch (8.66 KB, patch)
2021-11-21 21:25 PST, Jean-Yves Avenard [:jya] 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Yves Avenard [:jya] 2021-11-21 21:17:42 PST 
The method `bool getEOTHeader(SharedBuffer* fontData, EOTHeader& eotHeader, size_t& overlayDst, size_t& overlaySrc, size_t& overlayLength)` is unused in the code
Comment 1 Radar WebKit Bug Importer 2021-11-21 21:18:17 PST 
<rdar://problem/85656827>
Comment 2 Jean-Yves Avenard [:jya] 2021-11-21 21:21:51 PST 
Created attachment 444938 [details]
Patch
Comment 3 Jean-Yves Avenard [:jya] 2021-11-21 21:25:32 PST 
Created attachment 444939 [details]
Patch
Comment 4 Jean-Yves Avenard [:jya] 2021-11-21 21:39:50 PST 
To add: getEOTHeader requires a flattened SharedBuffer ; this code appears ancient, the symbol isn't exported and would require modification following bug 233030 which would make any customers incompatible anyway.
Comment 5 EWS 2021-11-22 12:35:13 PST 
Committed r286117 (244504@main): <https://commits.webkit.org/244504@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444939 [details].