The various compile-time flags are not well organized and their use throughout the code related to <model> is a bit messy and lacking with regards to IDL method definitions.
Created attachment 444923 [details] Patch
r- because it seems like this entirely regresses https://trac.webkit.org/changeset/282567/webkit; I'll retract my r- if you build with SEPARATED_MODEL on and everything works.
Created attachment 445077 [details] Patch
(In reply to Tim Horton from comment #2) > r- because it seems like this entirely regresses > https://trac.webkit.org/changeset/282567/webkit; I'll retract my r- if you > build with SEPARATED_MODEL on and everything works. The new patch retains ENABLE_ARKIT_INLINE_PREVIEW accounting for the changes made in r 282567.
<rdar://problem/85786210>
Comment on attachment 445077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445077&action=review > Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:58 > -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS) > +#if HAVE(ASV_INLINE_PREVIEW_IOS) Should just remove this ifdef, it's a lie > Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:95 > -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS) > +#if HAVE(ASV_INLINE_PREVIEW_IOS) Should just remove this ifdef, it's a lie
Committed r286227 (244608@main): <https://commits.webkit.org/244608@main>
Re-opened since this is blocked by bug 233652