Bug 233407 - [Model] clean up compile-time flags and condition IDL methods behind them
Summary: [Model] clean up compile-time flags and condition IDL methods behind them
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on: 233652
Blocks:
  Show dependency treegraph
 
Reported: 2021-11-21 03:09 PST by Antoine Quint
Modified: 2021-11-30 12:05 PST (History)
10 users (show)

See Also:


Attachments
Patch (73.89 KB, patch)
2021-11-21 03:12 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (58.47 KB, patch)
2021-11-24 00:29 PST, Antoine Quint
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-11-21 03:09:53 PST
The various compile-time flags are not well organized and their use throughout the code related to <model> is a bit messy and lacking with regards to IDL method definitions.
Comment 1 Antoine Quint 2021-11-21 03:12:31 PST
Created attachment 444923 [details]
Patch
Comment 2 Tim Horton 2021-11-21 14:03:46 PST
r- because it seems like this entirely regresses https://trac.webkit.org/changeset/282567/webkit; I'll retract my r- if you build with SEPARATED_MODEL on and everything works.
Comment 3 Antoine Quint 2021-11-24 00:29:52 PST
Created attachment 445077 [details]
Patch
Comment 4 Antoine Quint 2021-11-24 00:30:20 PST
(In reply to Tim Horton from comment #2)
> r- because it seems like this entirely regresses
> https://trac.webkit.org/changeset/282567/webkit; I'll retract my r- if you
> build with SEPARATED_MODEL on and everything works.

The new patch retains ENABLE_ARKIT_INLINE_PREVIEW accounting for the changes made in r 282567.
Comment 5 Radar WebKit Bug Importer 2021-11-28 03:10:20 PST
<rdar://problem/85786210>
Comment 6 Tim Horton 2021-11-29 10:40:35 PST
Comment on attachment 445077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445077&action=review

> Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:58
> -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS)
> +#if HAVE(ASV_INLINE_PREVIEW_IOS)

Should just remove this ifdef, it's a lie

> Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:95
> -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS)
> +#if HAVE(ASV_INLINE_PREVIEW_IOS)

Should just remove this ifdef, it's a lie
Comment 7 Antoine Quint 2021-11-29 11:06:48 PST
Committed r286227 (244608@main): <https://commits.webkit.org/244608@main>
Comment 8 WebKit Commit Bot 2021-11-30 12:05:09 PST
Re-opened since this is blocked by bug 233652