[WebGPU] Send WebGPU messages in the web process
Created attachment 444894 [details] Patch
Created attachment 444905 [details] Patch
Created attachment 444906 [details] Patch
Comment on attachment 444905 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444905&action=review > Source/WebKit/Shared/WebGPU/WebGPUBindGroupEntry.cpp:44 > + /* > + PAL::WebGPU::Index32 binding; > + BufferBinding bufferBinding; > + WebGPUIdentifier identifier; > + BindingResourceType type; > + */ Did you mean to leave this here?
Comment on attachment 444906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444906&action=review > Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.cpp:58 > + auto depthStencilAttachment = ([&] () -> std::optional<RenderPassDepthStencilAttachment> { > + if (renderPassDescriptor.depthStencilAttachment) > + return convertToBacking(*renderPassDescriptor.depthStencilAttachment); > + return std::nullopt; > + })(); > + if (renderPassDescriptor.depthStencilAttachment && !depthStencilAttachment) > + return std::nullopt; Isn't it less lines to simply do: std::optional<RenderPassDepthStencilAttachment> depthStencilAttachment; if (renderPassDescriptor.depthStencilAttachment) { depthStencilAttachment = convertToBacking(*renderPassDescriptor.depthStencilAttachment); if (!depthStencilAttachment) return std::nullopt; } > Source/WebKit/Shared/WebGPU/WebGPURenderPipelineDescriptor.cpp:74 > + auto fragment = ([&] () -> std::optional<FragmentState> { > + if (renderPipelineDescriptor.fragment) > + return convertToBacking(*renderPipelineDescriptor.fragment); > + return std::nullopt; > + })(); > + if (renderPipelineDescriptor.fragment && !fragment) > + return std::nullopt; Another one here.
Comment on attachment 444906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444906&action=review >> Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.cpp:58 >> + return std::nullopt; > > Isn't it less lines to simply do: > > std::optional<RenderPassDepthStencilAttachment> depthStencilAttachment; > if (renderPassDescriptor.depthStencilAttachment) { > depthStencilAttachment = convertToBacking(*renderPassDescriptor.depthStencilAttachment); > if (!depthStencilAttachment) > return std::nullopt; > } yessssss will do.
Created attachment 444907 [details] Patch for committing
Committed r286098 (244485@main): <https://commits.webkit.org/244485@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444907 [details].
<rdar://problem/85638093>