Bug 23339 – Add preference to disable web security

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Barth]

As discussed on IRC, web developers find it useful to disable the same-origin policy when regression testing their web site (e.g., with Selenium).  Firefox has this option.  So should we.

Patch forthcoming.

[Adam Barth]

Created attachment 26745 [details]
patch

[Mark Rowe (bdash)]

These methods should be added to WebPreferencesPrivate rather than WebPreferences as they need to go through Apple API review before they can be added to an API header file.

[Adam Barth]

Comment on attachment 26745 [details]
patch

Ok.  Clearing review flag.

[Adam Barth]

Created attachment 26747 [details]
patch

I figured out how to do this for mac.  Is there a similar issue on windows?

[Mark Rowe (bdash)]

Steve or Adam Roben would know what our policy is for API vs SPI on Windows.

[Steve Falkenburg]

We make the Windows API change in the interface that matches the Mac.  So WebPreferences->IWebPreferences, WebPreferencesPrivate->IWebPreferencesPrivate.

One problem with your patch: you need to add new methods to COM interfaces at the *end* to preserve the vtable order.  Otherwise, you break compatibility.

[Adam Barth]

Comment on attachment 26747 [details]
patch

Ok.  Will do.  Clearing review flag while I re-spin the patch.

[Adam Barth]

Created attachment 26828 [details]
patch (privatized)

This version should address the above comments (thanks!).

[Adam Barth]

Friendly ping.  :)

(I secretly want to land this because it will help with Bug 20249.)

[Sam Weinig]

Comment on attachment 26828 [details]
patch (privatized)

Doh.  r=me

[Adam Barth]

(In reply to comment #10)
> Doh.  r=me

Thanks Sam.

[Adam Barth]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       WebCore/ChangeLog
        M       WebCore/WebCore.base.exp
        M       WebCore/dom/Document.cpp
        M       WebCore/page/SecurityOrigin.cpp
        M       WebCore/page/SecurityOrigin.h
        M       WebCore/page/Settings.cpp
        M       WebCore/page/Settings.h
        M       WebKit/mac/ChangeLog
        M       WebKit/mac/WebView/WebPreferenceKeysPrivate.h
        M       WebKit/mac/WebView/WebPreferences.mm
        M       WebKit/mac/WebView/WebPreferencesPrivate.h
        M       WebKit/mac/WebView/WebView.mm
        M       WebKit/win/ChangeLog
        M       WebKit/win/Interfaces/IWebPreferencesPrivate.idl
        M       WebKit/win/WebPreferenceKeysPrivate.h
        M       WebKit/win/WebPreferences.cpp
        M       WebKit/win/WebPreferences.h
        M       WebKit/win/WebView.cpp
Committed r40449