RESOLVED FIXED 233365
[Model] add audio support 
https://bugs.webkit.org/show_bug.cgi?id=233365
Summary [Model] add audio support
Antoine Quint
Reported 2021-11-19 07:13:48 PST
[Model] add audio support
Attachments
Patch (26.58 KB, patch)
2021-11-19 07:19 PST, Antoine Quint 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-11-19 07:19:12 PST
Created attachment 444817 [details] Patch
Antoine Quint
Comment 2 2021-11-19 07:19:18 PST
<rdar://problem/85428982>
Wenson Hsieh
Comment 3 2021-11-19 09:00:25 PST
Comment on attachment 444817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444817&action=review > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:160 > + auto* strongPage = m_page.get(); This should either be `RefPtr strongPage = m_page.get();`, or we shouldn't call it `strongPage`. > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:186 > + auto* strongPage = m_page.get(); (Ditto) > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:212 > + auto* strongPage = m_page.get(); (Ditto)
Antoine Quint
Comment 4 2021-11-19 09:42:53 PST
Committed r286065 (244452@main): <https://commits.webkit.org/244452@main>
Antoine Quint
Comment 5 2021-11-19 10:01:14 PST
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 444817 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444817&action=review > > > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:160 > > + auto* strongPage = m_page.get(); > > This should either be `RefPtr strongPage = m_page.get();`, or we shouldn't > call it `strongPage`. I adopted `RefPtr` in the commit in all places.
Tim Horton
Comment 6 2021-11-19 11:00:29 PST
Comment on attachment 444817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444817&action=review > Source/WTF/ChangeLog:9 > + Add a new compile-time flag for the new autio-related ARQL SPIs we are using. "autio"
Note You need to log in before you can comment on or make changes to this bug.