Bug 233365 - [Model] add audio support
Summary: [Model] add audio support
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-19 07:13 PST by Antoine Quint
Modified: 2021-11-19 11:00 PST (History)
9 users (show)

See Also:

Attachments
Patch (26.58 KB, patch)
2021-11-19 07:19 PST, Antoine Quint 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2021-11-19 07:13:48 PST 
[Model] add audio support
Comment 1 Antoine Quint 2021-11-19 07:19:12 PST 
Created attachment 444817 [details]
Patch
Comment 2 Antoine Quint 2021-11-19 07:19:18 PST 
<rdar://problem/85428982>
Comment 3 Wenson Hsieh 2021-11-19 09:00:25 PST 
Comment on attachment 444817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444817&action=review

> Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:160
> +    auto* strongPage = m_page.get();

This should either be `RefPtr strongPage = m_page.get();`, or we shouldn't call it `strongPage`.

> Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:186
> +    auto* strongPage = m_page.get();

(Ditto)

> Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:212
> +    auto* strongPage = m_page.get();

(Ditto)
Comment 4 Antoine Quint 2021-11-19 09:42:53 PST 
Committed r286065 (244452@main): <https://commits.webkit.org/244452@main>
Comment 5 Antoine Quint 2021-11-19 10:01:14 PST 
(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 444817 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444817&action=review
> 
> > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:160
> > +    auto* strongPage = m_page.get();
> 
> This should either be `RefPtr strongPage = m_page.get();`, or we shouldn't
> call it `strongPage`.

I adopted `RefPtr` in the commit in all places.
Comment 6 Tim Horton 2021-11-19 11:00:29 PST 
Comment on attachment 444817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444817&action=review

> Source/WTF/ChangeLog:9
> +        Add a new compile-time flag for the new autio-related ARQL SPIs we are using.

"autio"