Bug 233341 - SubSpace constructors should take a const HeapCellType& instead of a HeapCellType*.
Summary: SubSpace constructors should take a const HeapCellType& instead of a HeapCel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-18 16:22 PST by Mark Lam
Modified: 2021-11-18 19:03 PST (History)
11 users (show)

See Also:


Attachments
[fast-cq] proposed patch. (197.57 KB, patch)
2021-11-18 16:30 PST, Mark Lam
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-11-18 16:22:22 PST
This helps document that the HeapCellTypes are immutable once they are instantiated, and that SubSpaces won't be modifying them.

Also remove the const on CellAttributes return values since it is not needed nor meaningful.
Comment 1 Radar WebKit Bug Importer 2021-11-18 16:22:56 PST
<rdar://problem/85573277>
Comment 2 Mark Lam 2021-11-18 16:30:33 PST
Created attachment 444756 [details]
[fast-cq] proposed patch.
Comment 3 Yusuke Suzuki 2021-11-18 17:45:49 PST
Comment on attachment 444756 [details]
[fast-cq] proposed patch.

r=me
Comment 4 Mark Lam 2021-11-18 19:01:36 PST
Comment on attachment 444756 [details]
[fast-cq] proposed patch.

Thanks for the review.
Comment 5 EWS 2021-11-18 19:03:56 PST
Committed r286042 (244430@main): <https://commits.webkit.org/244430@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444756 [details].