Bug 233327 - [GTK] Fix ANGLE compilation
Summary: [GTK] Fix ANGLE compilation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alejandro G. Castro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-18 12:23 PST by Alejandro G. Castro
Modified: 2021-12-13 13:18 PST (History)
11 users (show)

See Also:

Attachments
Patch (6.38 KB, patch)
2021-11-18 12:39 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Patch (7.71 KB, patch)
2021-12-13 09:28 PST, Alejandro G. Castro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2021-11-18 12:23:40 PST 
We want to fix the prototype implementation we have for GTK, this is not the solution we are going to use in the end but it is a good first step that allows us to collaborate and have reference solution to compare. This is the first patch in the series to enable WebGL support for GTK and WPE using ANGLE.
Comment 1 Alejandro G. Castro 2021-11-18 12:39:46 PST 
Created attachment 444719 [details]
Patch
Comment 2 EWS Watchlist 2021-11-18 12:40:25 PST 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alejandro G. Castro 2021-12-13 09:28:31 PST 
Created attachment 447016 [details]
Patch
Comment 4 Kenneth Russell 2021-12-13 13:07:18 PST 
Comment on attachment 447016 [details]
Patch

Looks good; let's get GTK on the ANGLE backend ASAP. r+
Comment 5 EWS 2021-12-13 13:17:38 PST 
Committed r286978 (?): <https://commits.webkit.org/r286978>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 447016 [details].
Comment 6 Radar WebKit Bug Importer 2021-12-13 13:18:22 PST 
<rdar://problem/86430088>