WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 233320
Update shadow DOM and dialog element focusing to latest spec
https://bugs.webkit.org/show_bug.cgi?id=233320
Summary
Update shadow DOM and dialog element focusing to latest spec
Domenic Denicola
Reported
2021-11-18 10:17:54 PST
The spec was previously not shadow DOM aware. In
https://github.com/whatwg/html/pull/7285
we made it behave the same as delegatesFocus: they both "delegate focus" to either autofocus="" if it's specified on a (non-shadow-including) descendant, or the first focusable element among their shadow-including descendants if not. Tests:
https://github.com/web-platform-tests/wpt/pull/31523
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2021-11-25 10:18:18 PST
<
rdar://problem/85753180
>
Domenic Denicola
Comment 2
2022-01-31 08:15:55 PST
After
https://github.com/whatwg/html/pull/7361
and
https://github.com/web-platform-tests/wpt/pull/31724
I believe this algorithm is now in good shape and implementable.
Jouni Koivuviita
Comment 3
2022-03-07 05:35:26 PST
I’m not entirely sure this is 100% related or worthy a new bug report, but there’s an issue in Safari Tech Preview 141, when the dialog and the content of the dialog are in different DOM "scopes" (light DOM vs shadow DOM). The content is not focusable at all using the Tab key, and the dialog is not closed when clicking a button inside a <form method="dialog">. Here’s a test case I created for the four different cases:
https://jsbin.com/finugon/
- Dialog and content in light DOM (works) - Dialog in light DOM, content in shadow DOM (broken) - Dialog and content in shadow DOM (works) - Dialog in shadow DOM, content in light DOM (slotted) (broken)
Tim Nguyen (:ntim)
Comment 4
2022-07-28 15:33:14 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/2828
EWS
Comment 5
2022-07-29 13:01:30 PDT
Committed
252959@main
(696e8c1c47e2): <
https://commits.webkit.org/252959@main
> Reviewed commits have been landed. Closing PR #2828 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug