Bug 233294 – Web Inspector: allow left docking when in LTR and right docking when in RTL

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Some developers prefer docking to the left even when in LTR and/or docking to the right when in RTL. There's no technical reason to disallow this, so let's make it possible.

[Devin Rousso]

Created attachment 444604 [details]
Patch

[Devin Rousso]

Created attachment 444605 [details]
[Image] after Patch is applied (undocked - light)

[Patrick Angle]

Comment on attachment 444604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444604&action=review

Looks good to me, but needs to account for RTL layouts where the icons will be laid out in the reverse order, even though the sides they represent remain fixed.

> Source/WebInspectorUI/UserInterface/Base/Main.js:362
> +    if (supportsDockLeft && (supportsDockRight || supportsDockBottom || supportsUndocked)) {

I think the order of icons is going to be unintuitive in RTL languages - The icons will be placed on the rightmost edge of the tab bar in that case, with the docked items arranged visually as ["windowed", "right", "bottom", "left", "windowed"] (with one of those options hidden at any given time) and not ["windowed", "left", "bottom", "right"], so I think we still need to check WI.resolvedLayoutDirection and make sure the order of these buttons make sense.

[Devin Rousso]

Created attachment 444617 [details]
Patch

[Devin Rousso]

Created attachment 444618 [details]
Patch

[Patrick Angle]

Comment on attachment 444618 [details]
Patch

Nice! r=me

[EWS]

Committed r285974 (244371@main): <https://commits.webkit.org/244371@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444618 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85531803>