Bug 233291 - [css-values-4] Dynamic `dv*` viewport units should not respect the page scale
Summary: [css-values-4] Dynamic `dv*` viewport units should not respect the page scale
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 219287
Blocks: 238673
  Show dependency tree / graph
 
Reported: 2021-11-17 16:21 PST by Devin Rousso
Modified: 2022-05-31 22:39 PDT (History)
5 users (show)

See Also:

Attachments
Patch (22.59 KB, patch)
2021-11-17 16:27 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (28.18 KB, patch)
2021-11-18 00:26 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (25.91 KB, patch)
2021-11-18 14:19 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (23.01 KB, patch)
2021-11-18 14:28 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (24.68 KB, patch)
2021-11-30 12:53 PST, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-11-17 16:21:51 PST 
.
Comment 1 Devin Rousso 2021-11-17 16:27:54 PST 
Created attachment 444599 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-11-17 16:35:14 PST 
Comment on attachment 444599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444599&action=review

> Source/WebCore/page/FrameView.cpp:5680
> +    return layoutViewportRect().size();

Have you tested the behavior in MobileSafari/SFSafariViewController/Web.app?
Comment 3 Devin Rousso 2021-11-17 16:43:49 PST 
Comment on attachment 444599 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444599&action=review

>> Source/WebCore/page/FrameView.cpp:5680
>> +    return layoutViewportRect().size();
> 
> Have you tested the behavior in MobileSafari/SFSafariViewController/Web.app?

I tested MobileSafari and `SFSafariViewController`.  I forgot about Web.app, but I just tested it there as well.  All misbehave before this patch (`dv*` changes with scale) and correctly work (`dv*` is constant through scaling) after this patch :)
Comment 4 Devin Rousso 2021-11-18 00:26:08 PST 
Created attachment 444644 [details]
Patch
Comment 5 Devin Rousso 2021-11-18 14:19:31 PST 
Created attachment 444736 [details]
Patch
Comment 6 Devin Rousso 2021-11-18 14:28:28 PST 
Created attachment 444738 [details]
Patch
Comment 7 Radar WebKit Bug Importer 2021-11-24 16:22:21 PST 
<rdar://problem/85735818>
Comment 8 Devin Rousso 2021-11-30 12:53:53 PST 
Created attachment 445455 [details]
Patch
Comment 9 EWS 2021-11-30 22:32:31 PST 
Committed r286350 (244709@main): <https://commits.webkit.org/244709@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445455 [details].