Upstream remaining files from platform/chromium/ From here: http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
Created attachment 26721 [details] v1 patch These are the files that you already reviewed for WebKit style compliance. I hope the change isn't too large.
I removed the "using namespace WebCore;" from TemporaryLinkStubs.cpp locally.
Comment on attachment 26721 [details] v1 patch notImplemented()? IntSize dragImageSize(DragImageRef image) 39 { 40 return IntSize(); 41 } 42 Other code seems to prefer just "unsigned" over "unsigned int": 36 int windowsKeyCodeForKeyEvent(unsigned int keycode); It's a little funny just to wrap this one line: 2 ChromiumBridge::clipboardWriteSelection(html, url, plainText, 83 canSmartCopyOrDelete); "event" is not needed here: 78 virtual bool handleMouseDownEvent(const PlatformMouseEvent& event); 79 virtual bool handleMouseMoveEvent(const PlatformMouseEvent& event); 80 virtual bool handleMouseReleaseEvent(const PlatformMouseEvent& event); 81 virtual bool handleWheelEvent(const PlatformWheelEvent& event); 82 virtual bool handleKeyEvent(const PlatformKeyboardEvent& event); Generally I've seen WebCore avoid this kind of construction: 894 m_originalIndex = m_selectedIndex = index; But I'm not sure we have any specific style rules about it. No longer required after your previous change: // Required to use notImplemented() outside of the WebCore namespace. 49 using namespace WebCore; I have no substantive comments. This looks fine as-is.
http://trac.webkit.org/changeset/39903