Bug 23328 - Upstream remaining files from platform/chromium/
Summary: Upstream remaining files from platform/chromium/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 11:21 PST by Darin Fisher (:fishd, Google)
Modified: 2009-01-14 11:53 PST (History)
0 users

See Also:


Attachments
v1 patch (176.20 KB, patch)
2009-01-14 11:22 PST, Darin Fisher (:fishd, Google)
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-01-14 11:21:29 PST
Upstream remaining files from platform/chromium/

From here:
http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/WebKit/WebCore/platform/chromium/
Comment 1 Darin Fisher (:fishd, Google) 2009-01-14 11:22:52 PST
Created attachment 26721 [details]
v1 patch

These are the files that you already reviewed for WebKit style compliance.  I hope the change isn't too large.
Comment 2 Darin Fisher (:fishd, Google) 2009-01-14 11:25:08 PST
I removed the "using namespace WebCore;" from TemporaryLinkStubs.cpp locally.
Comment 3 Eric Seidel (no email) 2009-01-14 11:34:06 PST
Comment on attachment 26721 [details]
v1 patch

notImplemented()?
 IntSize dragImageSize(DragImageRef image)
 39 {
 40     return IntSize();
 41 }
 42 

Other code seems to prefer just "unsigned" over "unsigned int":
 36     int windowsKeyCodeForKeyEvent(unsigned int keycode);

It's a little funny just to wrap this one line:
2     ChromiumBridge::clipboardWriteSelection(html, url, plainText,
 83                                             canSmartCopyOrDelete);

"event" is not needed here:
78     virtual bool handleMouseDownEvent(const PlatformMouseEvent& event);
 79     virtual bool handleMouseMoveEvent(const PlatformMouseEvent& event);
 80     virtual bool handleMouseReleaseEvent(const PlatformMouseEvent& event);
 81     virtual bool handleWheelEvent(const PlatformWheelEvent& event);
 82     virtual bool handleKeyEvent(const PlatformKeyboardEvent& event);

Generally I've seen WebCore avoid this kind of construction:
894     m_originalIndex = m_selectedIndex = index;
But I'm not sure we have any specific style rules about it.

No longer required after your previous change:
// Required to use notImplemented() outside of the WebCore namespace.
 49 using namespace WebCore;

I have no substantive comments.  This looks fine as-is.
Comment 4 Darin Fisher (:fishd, Google) 2009-01-14 11:53:13 PST
http://trac.webkit.org/changeset/39903