RESOLVED FIXED233268
Implement most of redirect and modify-headers action types 
https://bugs.webkit.org/show_bug.cgi?id=233268
Summary Implement most of redirect and modify-headers action types
Alex Christensen
Reported 2021-11-17 11:51:50 PST
Implement most of redirect and modify-headers action types
Attachments
Patch (96.29 KB, patch)
2021-11-17 13:20 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (96.48 KB, patch)
2021-11-17 13:51 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (93.27 KB, patch)
2021-11-17 14:30 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (93.34 KB, patch)
2021-11-17 15:39 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (110.48 KB, patch)
2021-11-17 16:32 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (110.45 KB, patch)
2021-11-17 17:06 PST, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (111.40 KB, patch)
2021-11-17 20:18 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-11-17 13:20:56 PST
Created attachment 444559 [details] Patch
Alex Christensen
Comment 2 2021-11-17 13:51:52 PST
Created attachment 444567 [details] Patch
Alex Christensen
Comment 3 2021-11-17 14:30:36 PST
Created attachment 444578 [details] Patch
Alex Christensen
Comment 4 2021-11-17 15:39:02 PST
Created attachment 444591 [details] Patch
Timothy Hatcher
Comment 5 2021-11-17 15:49:54 PST
Comment on attachment 444591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444591&action=review > Source/WebCore/contentextensions/ContentExtensionError.cpp:107 > + return "A redirect ur lscheme must be a valid scheme"; "ur lscheme" => "url scheme" > Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:106 > + activeContentRuleListActionsPatterns(), Should this (and in other places) be "activeContentRuleListActionPatterns" (to avoid the double plural)?
Alex Christensen
Comment 6 2021-11-17 16:32:38 PST
Created attachment 444600 [details] Patch
Alex Christensen
Comment 7 2021-11-17 17:06:35 PST
Created attachment 444612 [details] Patch
Alex Christensen
Comment 8 2021-11-17 20:18:36 PST
Created attachment 444633 [details] Patch
EWS Watchlist
Comment 9 2021-11-17 20:19:53 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alex Christensen
Comment 10 2021-11-17 21:38:53 PST
r285980
Radar WebKit Bug Importer
Comment 11 2021-11-17 21:39:21 PST
<rdar://problem/85534516>
Note You need to log in before you can comment on or make changes to this bug.