Bug 233264 - Web Inspector: fix IPC race between unregistering an extension and Web Inspector closing
Summary: Web Inspector: fix IPC race between unregistering an extension and Web Inspec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-17 11:17 PST by BJ Burg
Modified: 2021-11-30 10:53 PST (History)
7 users (show)

See Also:

Attachments
Patch v1.0 (2.95 KB, patch)
2021-11-17 11:21 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Patch 1.0.1 (for landing) (2.94 KB, patch)
2021-11-30 09:58 PST, BJ Burg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2021-11-17 11:17:23 PST 
.
Comment 1 BJ Burg 2021-11-17 11:21:14 PST 
Created attachment 444540 [details]
Patch v1.0
Comment 2 Devin Rousso 2021-11-17 12:03:07 PST 
Comment on attachment 444540 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=444540&action=review

r=me

> Source/WebKit/UIProcess/Inspector/WebInspectorUIExtensionControllerProxy.cpp:89
> +    m_extensionAPIObjectMap.clear();

Style: add newline before
Comment 3 Radar WebKit Bug Importer 2021-11-17 16:51:11 PST 
<rdar://problem/85526823>
Comment 4 BJ Burg 2021-11-30 09:58:04 PST 
Created attachment 445430 [details]
Patch 1.0.1 (for landing)
Comment 5 EWS 2021-11-30 10:53:32 PST 
Committed r286306 (244665@main): <https://commits.webkit.org/244665@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445430 [details].