Bug 233255 - Create a RecordingSwizzleType::Object to avoid duplicating data
Summary: Create a RecordingSwizzleType::Object to avoid duplicating data
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-17 07:49 PST by Lauro Moura
Modified: 2021-11-24 07:50 PST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-11-17 07:49:54 PST 
bug232780 added a method that takes an array of DOMPointInit. In the proposed patch, the InspectorCanvas method creates a JSON::Object for each DOMPointInit and returns an array with RecordingSwizzleType::Array.

From the review:

> While I do think this will work, a primary goal of this entire system is to avoid duplicating data since all of it has to be serialized and sent over the Web Inspector connection (which could be communicating with an entire other device, such as when inspecting an iOS device from a macOS machine).

> As such, we probably want to create either a new `RecordingSwizzleType::DOMPointInit` or a more generic `RecordingSwizzleType::Object` so that if multiple calls to `roundRect` are made with the same `radii` argument we don't encode the same data more than once.
Comment 1 Radar WebKit Bug Importer 2021-11-24 07:50:22 PST 
<rdar://problem/85728617>