Bug 23325 - Upstream even more of platform/graphics/chromium
Summary: Upstream even more of platform/graphics/chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 10:53 PST by Dimitri Glazkov (Google)
Modified: 2009-01-14 11:29 PST (History)
0 users

See Also:

Attachments
upstream even more graphics/chromium bits (33.96 KB, patch)
2009-01-14 10:54 PST, Dimitri Glazkov (Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-01-14 10:53:52 PST 
Another batch that covers GlyphPageTreeNode, Icon, and ImageBuffer-related files.
Comment 1 Dimitri Glazkov (Google) 2009-01-14 10:54:42 PST 
Created attachment 26719 [details]
upstream even more graphics/chromium bits

 WebCore/ChangeLog                                  |   42 ++++
 .../chromium/GlyphPageTreeNodeChromiumWin.cpp      |  248 ++++++++++++++++++++
 .../graphics/chromium/GlyphPageTreeNodeLinux.cpp   |   72 ++++++
 .../graphics/chromium/IconChromiumLinux.cpp        |   66 ++++++
 .../platform/graphics/chromium/IconChromiumMac.cpp |   60 +++++
 .../platform/graphics/chromium/IconChromiumWin.cpp |   87 +++++++
 .../platform/graphics/chromium/ImageBufferData.h   |   50 ++++
 .../platform/graphics/chromium/ImageChromiumMac.mm |   58 +++++
 .../graphics/chromium/MediaPlayerPrivateChromium.h |  101 ++++++++
 WebCore/platform/graphics/chromium/PlatformIcon.h  |   42 ++++
 10 files changed, 826 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-01-14 11:16:50 PST 
Comment on attachment 26719 [details]
upstream even more graphics/chromium bits

I'm surprised the cast is necessary:
 74     HDC dc = GetDC((HWND)0);

The spacing in IconChromiumLinux.cpp is wrong.

Looks fine otherwise.
Comment 3 Dimitri Glazkov (Google) 2009-01-14 11:29:35 PST 
Committed in http://trac.webkit.org/changeset/39899 and http://trac.webkit.org/changeset/39900.