WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23325
Upstream even more of platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=23325
Summary
Upstream even more of platform/graphics/chromium
Dimitri Glazkov (Google)
Reported
2009-01-14 10:53:52 PST
Another batch that covers GlyphPageTreeNode, Icon, and ImageBuffer-related files.
Attachments
upstream even more graphics/chromium bits
(33.96 KB, patch)
2009-01-14 10:54 PST
,
Dimitri Glazkov (Google)
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-01-14 10:54:42 PST
Created
attachment 26719
[details]
upstream even more graphics/chromium bits WebCore/ChangeLog | 42 ++++ .../chromium/GlyphPageTreeNodeChromiumWin.cpp | 248 ++++++++++++++++++++ .../graphics/chromium/GlyphPageTreeNodeLinux.cpp | 72 ++++++ .../graphics/chromium/IconChromiumLinux.cpp | 66 ++++++ .../platform/graphics/chromium/IconChromiumMac.cpp | 60 +++++ .../platform/graphics/chromium/IconChromiumWin.cpp | 87 +++++++ .../platform/graphics/chromium/ImageBufferData.h | 50 ++++ .../platform/graphics/chromium/ImageChromiumMac.mm | 58 +++++ .../graphics/chromium/MediaPlayerPrivateChromium.h | 101 ++++++++ WebCore/platform/graphics/chromium/PlatformIcon.h | 42 ++++ 10 files changed, 826 insertions(+), 0 deletions(-)
Eric Seidel (no email)
Comment 2
2009-01-14 11:16:50 PST
Comment on
attachment 26719
[details]
upstream even more graphics/chromium bits I'm surprised the cast is necessary: 74 HDC dc = GetDC((HWND)0); The spacing in IconChromiumLinux.cpp is wrong. Looks fine otherwise.
Dimitri Glazkov (Google)
Comment 3
2009-01-14 11:29:35 PST
Committed in
http://trac.webkit.org/changeset/39899
and
http://trac.webkit.org/changeset/39900
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug