Bug 233244 – [TextureMapper][GraphicsLayerTextureMapper][GraphicsLayerWC] setBackgroundColor support

• Status: RESOLVED
• Resolution: FIXED
• Component: Compositing

[Fujii Hironori]

[TextureMapper][GraphicsLayerTextureMapper][GraphicsLayerWC] setBackgroundColor support

TextureMapper, GraphicsLayerTextureMapper and GraphicsLayerWC don't support setBackgroundColor now.
setBackgroundColor is used for "painting flush" of Web Inspector Elements tab.

1. Start WinCairo MiniBrowser
2. Open Web Inspector
3. Push "Enable painting flush" brush icon button
4. Browsing some web sites

No repaint rect is painted with semi-transparent red.

[Fujii Hironori]

Created attachment 444488 [details]
Patch

[Don Olmstead]

Comment on attachment 444488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444488&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperSolidColorLayer.h:36
> +    static Color blendWithOpacity(const Color& color, float opacity)

This seems more like a utility method for Color. Anything like this already exist?

[Carlos Alberto Lopez Perez]

Comment on attachment 444488 [details]
Patch

This patch causes 161 unexpected failures on GTK.

This was reported by the GTK EWS Layout Test bot (still not public, is in testing phase)

I tested it locally and I confirm the failures are new.

Results here: https://people.igalia.com/clopez/wkbug/233244/layout-test-results/results.html

[Fujii Hironori]

(In reply to Carlos Alberto Lopez Perez from comment #3)

Thank you very much! I will test it and fix.

[Fujii Hironori]

Comment on attachment 444488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444488&action=review

>> Source/WebCore/platform/graphics/texmap/TextureMapperSolidColorLayer.h:36
>> +    static Color blendWithOpacity(const Color& color, float opacity)
> 
> This seems more like a utility method for Color. Anything like this already exist?

Color::colorWithAlphaMultipliedBy is the one.
By grepping WebKit source with colorWithAlphaMultipliedBy, some code use colorWithAlphaMultipliedBy directly.
I think this color calculation for solid color layers isn't performance critical.
I think we can simply use Color::colorWithAlphaMultipliedBy here. Will fix.

[Fujii Hironori]

Created attachment 444643 [details]
Patch

[Carlos Alberto Lopez Perez]

(In reply to Fujii Hironori from comment #6)
> Created attachment 444643 [details]
> Patch

This last version of the patch passed just fine on the beta GTK EWS. Thanks!

[Fujii Hironori]

Comment on attachment 444643 [details]
Patch

Clearing flags on attachment: 444643

Committed r286046 (244433@main): <https://commits.webkit.org/244433@main>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/85587165>

[Fujii Hironori]

It introduced a bug.
Filed: Bug 235152 – [WinCairo] REGRESSION(r286046): WebInspector doesn't render element highlight