Bug 233232 – AX: Fix 5 tests in --release --accessibility-isolated-tree mode

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Tyler Wilcock]

Fix 5 more tests in --release --accessibility-isolated-tree mode

[Radar WebKit Bug Importer]

<rdar://problem/85487292>

[Tyler Wilcock]

Created attachment 444469 [details]
Patch

[chris fleizach]

Comment on attachment 444469 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444469&action=review

> LayoutTests/accessibility/aria-checkbox-checked.html:-39
> -                checkbox.focus();

why doesn't this setFocus() getFocusElemnt() method work in isolated tree mode?

[Tyler Wilcock]

(In reply to chris fleizach from comment #3)
> Comment on attachment 444469 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444469&action=review
> 
> > LayoutTests/accessibility/aria-checkbox-checked.html:-39
> > -                checkbox.focus();
> 
> why doesn't this setFocus() getFocusElemnt() method work in isolated tree
> mode?
It would work, but we'd have to wait asynchronously for the accessibilityController.focusedElement to catch up with the DOM focused element. This test used focusing elements as a round-about way of getting a reference to AccessibilityUIElement, and we can just use accessibleElementById directly instead to avoid unnecessary async waiting.

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #2)
> Created attachment 444469 [details]
> Patch

--- a/LayoutTests/accessibility/add-children-pseudo-element.html
+++ a/LayoutTests/accessibility/add-children-pseudo-element.html

+        var element;
+        setTimeout(async function() {
+            element = accessibilityController.accessibleElementById("float");

I think you can declare element inside the body of the async function.

--- a/LayoutTests/accessibility/auto-fill-types.html
+++ a/LayoutTests/accessibility/auto-fill-types.html

+        var textField, axTextField, contactsButton, credentialsButton;
+        setTimeout(async function() {
+            textField = document.getElementById("textfield");

No need to declare these outside the function body.

--- a/LayoutTests/accessibility/ax-value-with-search.html
+++ a/LayoutTests/accessibility/ax-value-with-search.html

+        var searchInput;
+        setTimeout(async function() {
+            searchInput = accessibilityController.accessibleElementById("searchInput");

Dito.

[EWS]

Committed r285937 (244346@main): <https://commits.webkit.org/244346@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444469 [details].

[Tyler Wilcock]

Sorry Andres, the patch has landed, so I'll address your comments in a follow-up.