Bug 233228 – Fix for accessibility/notification-listeners.html in isolated tree mode.

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Andres Gonzalez]

Fix for accessibility/notification-listeners.html in isolated tree mode.

[Radar WebKit Bug Importer]

<rdar://problem/85484341>

[Andres Gonzalez]

Created attachment 444462 [details]
Patch

[Tyler Wilcock]

Comment on attachment 444462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444462&action=review

> LayoutTests/accessibility/notification-listeners.html:23
> +            let select = await waitForElementById("select");

Does this need to await waitForElementById instead of accessibilityController.accessibleElementById? The selected item appears to be a static part of the document, so seems like it should be accessible by the latter.

[Tyler Wilcock]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 444462 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444462&action=review
> 
> > LayoutTests/accessibility/notification-listeners.html:23
> > +            let select = await waitForElementById("select");
> 
> Does this need to await waitForElementById instead of
> accessibilityController.accessibleElementById? The selected item appears to
> be a static part of the document, so seems like it should be accessible by
> the latter.
Nevermind, Andres responded elsewhere that using accessibilityController.accessibleElementById in this case results in flakiness (~10 runs of 1000). It's fine to leave as-is.

[Andres Gonzalez]

Created attachment 444465 [details]
Patch

[Andres Gonzalez]

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 444462 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444462&action=review
> 
> > LayoutTests/accessibility/notification-listeners.html:23
> > +            let select = await waitForElementById("select");
> 
> Does this need to await waitForElementById instead of
> accessibilityController.accessibleElementById? The selected item appears to
> be a static part of the document, so seems like it should be accessible by
> the latter.

Thanks for pointing this out. That was my original take as well, but it turns out that if we use accessibleElementByID, the test is flaky. Added details to the ChangeLog.

[EWS]

Committed r285924 (244333@main): <https://commits.webkit.org/244333@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444465 [details].