Bug 23322 - gtk2drawing.c: fix compile warnings
Summary: gtk2drawing.c: fix compile warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 10:32 PST by Adam Langley
Modified: 2009-01-26 12:56 PST (History)
0 users

See Also:

Attachments
proposed patch (8.72 KB, patch)
2009-01-14 10:36 PST, Adam Langley 		zimmermann: review-
Details | Formatted Diff | Diff
proposed patch v2 (7.11 KB, patch)
2009-01-26 10:50 PST, Adam Langley 		no flags Details | Formatted Diff | Diff
proposed patch (8.83 KB, patch)
2009-01-26 11:31 PST, Adam Langley 		zimmermann: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-01-14 10:32:20 PST 
gtk2drawing: fix compiler warnings

* g_object_set_data expects a gpointer as the last argument. Cast the
  TRUE/FALSE values to avoid a warning.
* gtk_tree_view_column_new doesn't return a GtkWidget.
Comment 1 Adam Langley 2009-01-14 10:36:06 PST 
Created attachment 26715 [details]
proposed patch
Comment 2 Nikolas Zimmermann 2009-01-22 21:00:29 PST 
Comment on attachment 26715 [details]
proposed patch

The patch looks fine, though I think using GINT_TO_POINTER(TRUE/FALSE) sounds more approriate, then just casting to (gpointer)? I'm not a Gtk expert, but I've seen the style I suggested before.
Comment 3 Adam Langley 2009-01-26 10:50:07 PST 
Created attachment 27038 [details]
proposed patch v2
Comment 4 Adam Langley 2009-01-26 10:50:26 PST 
Have updated patch with requested changes.
Comment 5 Nikolas Zimmermann 2009-01-26 11:20:48 PST 
Hi Adam,
I'm sure you've uploaded the wrong patch :-)

Regards,
Niko
Comment 6 Adam Langley 2009-01-26 11:31:22 PST 
Created attachment 27041 [details]
proposed patch
Comment 7 Adam Langley 2009-01-26 11:32:27 PST 
Opps, I did upload the wrong patch! Sorry about that.
Comment 8 Nikolas Zimmermann 2009-01-26 12:16:37 PST 
Comment on attachment 27041 [details]
proposed patch

Patch looks great, r=me.

> +        WARNING: NO TEST CASES ADDED OR CHANGED
You can leave out the line before landing.
Comment 9 Darin Fisher (:fishd, Google) 2009-01-26 12:56:24 PST 
http://trac.webkit.org/changeset/40255