Bug 23321 - Upstream more of platform/graphics/chromium
Summary: Upstream more of platform/graphics/chromium
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 10:07 PST by Dimitri Glazkov (Google)
Modified: 2009-01-14 11:40 PST (History)
0 users

See Also:

Attachments
upstream more bits of graphics/chromium (40.65 KB, patch)
2009-01-14 10:08 PST, Dimitri Glazkov (Google) 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2009-01-14 10:07:45 PST 
FontPlatform-related files in a batch.
Comment 1 Dimitri Glazkov (Google) 2009-01-14 10:08:53 PST 
Created attachment 26713 [details]
upstream more bits of graphics/chromium

 WebCore/ChangeLog                                  |   50 +++
 .../chromium/FontPlatformDataChromiumWin.cpp       |  156 +++++++++
 .../chromium/FontPlatformDataChromiumWin.h         |  130 ++++++++
 .../graphics/chromium/FontPlatformDataLinux.cpp    |  139 ++++++++
 .../graphics/chromium/FontPlatformDataLinux.h      |  112 +++++++
 .../graphics/chromium/FontUtilsChromiumWin.cpp     |  350 ++++++++++++++++++++
 .../graphics/chromium/FontUtilsChromiumWin.h       |   93 ++++++
 7 files changed, 1030 insertions(+), 0 deletions(-)
Comment 2 Eric Seidel (no email) 2009-01-14 11:13:02 PST 
Comment on attachment 26713 [details]
upstream more bits of graphics/chromium

class FontPlatformData
 50 {
{ should be on same line.

 338 int getStyleFromLogfont(const LOGFONT* logfont) {

{ should be on its own line. :)

Sigh.  WebKit is very anti *utils files.  I wonder if we can find a happier home for FontUtils functions.  We probably add a FIXME to the top of that file to the effect.
Comment 3 Dimitri Glazkov (Google) 2009-01-14 11:40:40 PST 
Committed in http://trac.webkit.org/changeset/39902