WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23321
Upstream more of platform/graphics/chromium
https://bugs.webkit.org/show_bug.cgi?id=23321
Summary
Upstream more of platform/graphics/chromium
Dimitri Glazkov (Google)
Reported
2009-01-14 10:07:45 PST
FontPlatform-related files in a batch.
Attachments
upstream more bits of graphics/chromium
(40.65 KB, patch)
2009-01-14 10:08 PST
,
Dimitri Glazkov (Google)
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1
2009-01-14 10:08:53 PST
Created
attachment 26713
[details]
upstream more bits of graphics/chromium WebCore/ChangeLog | 50 +++ .../chromium/FontPlatformDataChromiumWin.cpp | 156 +++++++++ .../chromium/FontPlatformDataChromiumWin.h | 130 ++++++++ .../graphics/chromium/FontPlatformDataLinux.cpp | 139 ++++++++ .../graphics/chromium/FontPlatformDataLinux.h | 112 +++++++ .../graphics/chromium/FontUtilsChromiumWin.cpp | 350 ++++++++++++++++++++ .../graphics/chromium/FontUtilsChromiumWin.h | 93 ++++++ 7 files changed, 1030 insertions(+), 0 deletions(-)
Eric Seidel (no email)
Comment 2
2009-01-14 11:13:02 PST
Comment on
attachment 26713
[details]
upstream more bits of graphics/chromium class FontPlatformData 50 { { should be on same line. 338 int getStyleFromLogfont(const LOGFONT* logfont) { { should be on its own line. :) Sigh. WebKit is very anti *utils files. I wonder if we can find a happier home for FontUtils functions. We probably add a FIXME to the top of that file to the effect.
Dimitri Glazkov (Google)
Comment 3
2009-01-14 11:40:40 PST
Committed in
http://trac.webkit.org/changeset/39902
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug