Bug 233203 - Add syscall telemetry in the Networking process
Summary: Add syscall telemetry in the Networking process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-16 10:50 PST by Per Arne Vollan
Modified: 2021-11-18 15:02 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.99 KB, patch)
2021-11-16 10:51 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (6.88 KB, patch)
2021-11-17 08:02 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2021-11-18 14:19 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-11-16 10:50:00 PST 
Add syscall telemetry in the Networking process on macOS and iOS.
Comment 1 Per Arne Vollan 2021-11-16 10:51:46 PST 
Created attachment 444409 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-11-17 07:58:26 PST 
<rdar://problem/85504351>
Comment 3 Per Arne Vollan 2021-11-17 08:02:07 PST 
Created attachment 444522 [details]
Patch
Comment 4 Brent Fulgham 2021-11-17 13:48:21 PST 
Comment on attachment 444522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444522&action=review

> Source/WebKit/Scripts/process-entitlements.sh:329
> +    plistbuddy Add :com.apple.private.security.message-filter bool YES

Did you intend to add this entitlement to the GPU Process in this patch?
Comment 5 Per Arne Vollan 2021-11-17 18:26:13 PST 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 444522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444522&action=review
> 
> > Source/WebKit/Scripts/process-entitlements.sh:329
> > +    plistbuddy Add :com.apple.private.security.message-filter bool YES
> 
> Did you intend to add this entitlement to the GPU Process in this patch?

Yes, the GPU process' sandbox already has the filter, but is missing the entitlement.

Thanks for reviewing!
Comment 6 Per Arne Vollan 2021-11-18 14:19:01 PST 
Created attachment 444735 [details]
Patch
Comment 7 EWS 2021-11-18 15:02:06 PST 
Committed r286032 (244420@main): <https://commits.webkit.org/244420@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444735 [details].