Bug 233202 – Web Inspector: [Cocoa] Indicate a request was sent through proxy/private relay in Network tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Cory Underwood]

There does not appear to be a way for the local (user) client via Web Inspector Tools to determine that a outbound network request is being routed through the private relay network.  This seems to be the case when the 'Hide IP Address' option is set to any value.  It would be appreciated if the ability to determine when the feature was used on requests was enabled either via the Network Panel, or via the ITP Debug specific functionality like the CNAME Cloaking Mitigation reporting was enabled.

[Radar WebKit Bug Importer]

<rdar://problem/85468354>

[Patrick Angle]

<rdar://81915515>

[Patrick Angle]

Created attachment 455832 [details]
Patch v1.0

[Patrick Angle]

Created attachment 455833 [details]
Screenshot of Patch v1.0 (Network Overview /w IP Addresses shown)

[Patrick Angle]

Created attachment 455834 [details]
Screenshot of Patch v1.0 (Network Details Headers)

[EWS Watchlist]

This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.

[Patrick Angle]

Comment on attachment 455832 [details]
Patch v1.0

GTK failures look real, and I suspect there may be Windows failures hiding behind the typical compilation issue.

[Devin Rousso]

Comment on attachment 455832 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=455832&action=review

r=me, neat!

> Source/WebCore/platform/network/NetworkLoadMetrics.h:137
> +    bool isProxyConnection;

Is this perhaps already covered by `PrivacyStance::Proxied`?

> Source/WebInspectorUI/UserInterface/Models/Resource.js:388
> +        return this._isProxyConnection ? WI.UIString("%s (Proxy)", "%s (Proxy) @ Resource Remote Address", "Label for the IP address of a proxy server used to retrieve a network resource.").format(this._remoteAddress) : this._remoteAddress;

Style: I'd split this onto separate lines.
```
if (this._isProxyConnection)
    return WI.UIString("%s (Proxy)", "%s (Proxy) @ Resource Remote Address", "Label for the IP address of a proxy server used to retrieve a network resource.").format(this._remoteAddress);

return this._remoteAddress;
```

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:906
> +            additionalMetrics->isProxyConnection = m.proxyConnection;

eww `m.`?  That could've used a better name :(

[Patrick Angle]

Comment on attachment 455832 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=455832&action=review

>> Source/WebCore/platform/network/NetworkLoadMetrics.h:137
>> +    bool isProxyConnection;
> 
> Is this perhaps already covered by `PrivacyStance::Proxied`?

`PrivacyStance::Proxied` only applies to "private proxies", not all proxies.

[Patrick Angle]

Created attachment 455945 [details]
Patch v1.1 - For EWS

[EWS]

Committed r292037 (248980@main): <https://commits.webkit.org/248980@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455945 [details].