RESOLVED FIXED233201
[IFC][Integration] Clear the preferredLogicalWidths dirty bits after calling LineLayout::computeIntrinsicWidthConstraints 
https://bugs.webkit.org/show_bug.cgi?id=233201
Summary [IFC][Integration] Clear the preferredLogicalWidths dirty bits after calling ...
alan
Reported 2021-11-16 10:34:35 PST
ssia
Attachments
Patch (1.66 KB, patch)
2021-11-16 10:36 PST, alan 		no flags
DetailsFormatted DiffDiff
Post review patch (1.21 KB, patch)
2021-11-17 10:53 PST, alan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2021-11-16 10:36:21 PST
Created attachment 444408 [details] Patch
EWS
Comment 2 2021-11-17 06:20:01 PST
Committed r285925 (244334@main): <https://commits.webkit.org/244334@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444408 [details].
Radar WebKit Bug Importer
Comment 3 2021-11-17 06:21:23 PST
<rdar://problem/85501834>
Darin Adler
Comment 4 2021-11-17 09:26:21 PST
Comment on attachment 444408 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444408&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:4583 > + return true; > return true; I think we can just keep one of these
alan
Comment 5 2021-11-17 09:47:54 PST
(In reply to Darin Adler from comment #4) > Comment on attachment 444408 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444408&action=review > > > Source/WebCore/rendering/RenderBlockFlow.cpp:4583 > > + return true; > > return true; > > I think we can just keep one of these oops!
alan
Comment 6 2021-11-17 09:49:17 PST
(In reply to zalan from comment #5) > (In reply to Darin Adler from comment #4) > > Comment on attachment 444408 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=444408&action=review > > > > > Source/WebCore/rendering/RenderBlockFlow.cpp:4583 > > > + return true; > > > return true; > > > > I think we can just keep one of these > oops! good spotting! thanks thanks
alan
Comment 7 2021-11-17 10:53:19 PST
Created attachment 444537 [details] Post review patch
alan
Comment 8 2021-11-17 11:03:32 PST
post review patch.
EWS
Comment 9 2021-11-17 11:48:25 PST
Committed r285946 (244349@main): <https://commits.webkit.org/244349@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444537 [details].
Note You need to log in before you can comment on or make changes to this bug.