Bug 23320 - Make it possible to use notImplemented outside of the WebCore namespace
Summary: Make it possible to use notImplemented outside of the WebCore namespace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Fisher (:fishd, Google)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-01-14 10:07 PST by Darin Fisher (:fishd, Google)
Modified: 2009-01-14 10:35 PST (History)
1 user (show)

See Also:

Attachments
v1 patch (1.14 KB, patch)
2009-01-14 10:15 PST, Darin Fisher (:fishd, Google) 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Fisher (:fishd, Google) 2009-01-14 10:07:36 PST 
Make it possible to use notImplemented outside of the WebCore namespace

Currently, you have to do "using namespace Webcore" in order to use notImplemented() outside the WebCore namespace.  Instead, we can just make a small tweak to the notImplemented() macro to avoid that.
Comment 1 Darin Fisher (:fishd, Google) 2009-01-14 10:15:05 PST 
Created attachment 26714 [details]
v1 patch
Comment 2 Darin Adler 2009-01-14 10:17:19 PST 
Comment on attachment 26714 [details]
v1 patch

If you're making the macro work in other namespaces, then I suggest ::WebCore::LogNotYetImplemented is even slightly better.

r=me
Comment 3 Darin Fisher (:fishd, Google) 2009-01-14 10:25:23 PST 
good idea!
Comment 4 Darin Fisher (:fishd, Google) 2009-01-14 10:35:12 PST 
http://trac.webkit.org/changeset/39894