WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
23320
Make it possible to use notImplemented outside of the WebCore namespace
https://bugs.webkit.org/show_bug.cgi?id=23320
Summary
Make it possible to use notImplemented outside of the WebCore namespace
Darin Fisher (:fishd, Google)
Reported
2009-01-14 10:07:36 PST
Make it possible to use notImplemented outside of the WebCore namespace Currently, you have to do "using namespace Webcore" in order to use notImplemented() outside the WebCore namespace. Instead, we can just make a small tweak to the notImplemented() macro to avoid that.
Attachments
v1 patch
(1.14 KB, patch)
2009-01-14 10:15 PST
,
Darin Fisher (:fishd, Google)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1
2009-01-14 10:15:05 PST
Created
attachment 26714
[details]
v1 patch
Darin Adler
Comment 2
2009-01-14 10:17:19 PST
Comment on
attachment 26714
[details]
v1 patch If you're making the macro work in other namespaces, then I suggest ::WebCore::LogNotYetImplemented is even slightly better. r=me
Darin Fisher (:fishd, Google)
Comment 3
2009-01-14 10:25:23 PST
good idea!
Darin Fisher (:fishd, Google)
Comment 4
2009-01-14 10:35:12 PST
http://trac.webkit.org/changeset/39894
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug