RESOLVED FIXED 233198
Web Inspector: Remove unused `dontCreateIfMissing` argument from CSSStyleDeclaration.prototype.propertyForName 
https://bugs.webkit.org/show_bug.cgi?id=233198
Summary Web Inspector: Remove unused `dontCreateIfMissing` argument from CSSStyleDecl...
Nikita Vasilyev
Reported Tuesday, November 16, 2021 5:52:49 PM UTC
`dontCreateIfMissing` is always true. We don't need to make it an argument.
Attachments
Patch (13.02 KB, patch)
2021-11-16 10:10 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (13.99 KB, patch)
2021-11-16 13:24 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 Tuesday, November 16, 2021 6:10:28 PM UTC
Created attachment 444405 [details] Patch Never liked a negation in the argument name anyway :p
Devin Rousso
Comment 2 Tuesday, November 16, 2021 8:29:31 PM UTC
Comment on attachment 444405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444405&action=review > Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:332 > + return bestMatchProperty; We should simplify `propertyForName` while we're at it. There's no reason to have an inline function `findMatch` that we only call once.
Nikita Vasilyev
Comment 3 Tuesday, November 16, 2021 9:24:07 PM UTC
Created attachment 444424 [details] Patch Done.
Devin Rousso
Comment 4 Tuesday, November 16, 2021 9:59:07 PM UTC
Comment on attachment 444424 [details] Patch r=me
EWS
Comment 5 Wednesday, November 17, 2021 12:23:27 AM UTC
Committed r285896 (244314@main): <https://commits.webkit.org/244314@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444424 [details].
Radar WebKit Bug Importer
Comment 6 Wednesday, November 17, 2021 12:24:22 AM UTC
<rdar://problem/85480781>
Note You need to log in before you can comment on or make changes to this bug.