Bug 233191 - [iOS] Do not require the web browser entitlement to opt into captive portal mode
Summary: [iOS] Do not require the web browser entitlement to opt into captive portal mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-16 08:02 PST by Chris Dumez
Modified: 2021-11-16 10:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.32 KB, patch)
2021-11-16 08:04 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (6.32 KB, patch)
2021-11-16 08:14 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-11-16 08:02:56 PST
Do not require the web browser entitlement to opt into captive portal mode on iOS, only require it to opt out.
Comment 1 Chris Dumez 2021-11-16 08:04:50 PST
Created attachment 444385 [details]
Patch
Comment 2 Brent Fulgham 2021-11-16 08:08:05 PST
Comment on attachment 444385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444385&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7750
> +        [preferences _setCaptivePortalModeEnabled:NO];

Nit: Whitespace is wrong here.
Comment 3 Chris Dumez 2021-11-16 08:14:33 PST
Created attachment 444388 [details]
Patch
Comment 4 Brent Fulgham 2021-11-16 08:21:29 PST
Comment on attachment 444388 [details]
Patch

Thank you!
Comment 5 EWS 2021-11-16 10:28:04 PST
Committed r285873 (244299@main): <https://commits.webkit.org/244299@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444388 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-16 10:29:35 PST
<rdar://problem/85464810>