Bug 233187 - [GTK][WPE] displayDidRefresh can shortcut waking up the scrolling thread
Summary: [GTK][WPE] displayDidRefresh can shortcut waking up the scrolling thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Lord
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-16 05:05 PST by Chris Lord
Modified: 2021-11-16 05:41 PST (History)
9 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2021-11-16 05:10 PST, Chris Lord 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Lord 2021-11-16 05:05:59 PST 
There's an #ifdef'd out bit of code in ThreadedScrollingTree::displayDidRefresh that will shortcut waking up the scrolling thread if there are no recently handled wheel events or active animations. This seems like an easy win - the code within the #ifdef has changed and perhaps didn't previously fully apply for us, but now does, so we should remove the #ifdef.
Comment 1 Chris Lord 2021-11-16 05:10:05 PST 
Created attachment 444371 [details]
Patch
Comment 2 EWS 2021-11-16 05:40:59 PST 
Committed r285858 (244284@main): <https://commits.webkit.org/244284@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444371 [details].
Comment 3 Radar WebKit Bug Importer 2021-11-16 05:41:24 PST 
<rdar://problem/85454805>