Bug 233169 - [WebGPU] Fix namespace comments
Summary: [WebGPU] Fix namespace comments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-15 21:50 PST by Myles C. Maxfield
Modified: 2021-11-16 12:25 PST (History)
2 users (show)

See Also:


Attachments
Patch (101.56 KB, patch)
2021-11-15 21:51 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff
Patch (101.59 KB, patch)
2021-11-15 21:51 PST, Myles C. Maxfield
achristensen: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-11-15 21:50:33 PST
[WebGPU] Fix namespace comments
Comment 1 Myles C. Maxfield 2021-11-15 21:51:06 PST
Created attachment 444344 [details]
Patch
Comment 2 Myles C. Maxfield 2021-11-15 21:51:39 PST
Created attachment 444345 [details]
Patch
Comment 3 Alex Christensen 2021-11-15 23:00:07 PST
Comment on attachment 444345 [details]
Patch

Sure.
Why is WebGPU inside namespace PAL at all?
Comment 4 Alex Christensen 2021-11-16 07:41:55 PST
Comment on attachment 444345 [details]
Patch

You may consider using C++17 nested namespace syntax to completely remove this instead.
namespace PAL::WebGPU {
...
} // namespace PAL::WebGPU
Comment 5 Myles C. Maxfield 2021-11-16 09:48:59 PST
(In reply to Alex Christensen from comment #3)
> Comment on attachment 444345 [details]
> Patch
> 
> Sure.
> Why is WebGPU inside namespace PAL at all?

This part of the WebGPU implementation is in pal/graphics/WebGPU, so I assumed that means it should get the PAL namespace. The parts that are in WebGPU.framework won't use the PAL namespace.
Comment 6 Myles C. Maxfield 2021-11-16 12:24:46 PST
Committed r285879 (244305@main): <https://commits.webkit.org/244305@main>
Comment 7 Radar WebKit Bug Importer 2021-11-16 12:25:21 PST
<rdar://problem/85469938>