RESOLVED FIXED 233169
[WebGPU] Fix namespace comments 
https://bugs.webkit.org/show_bug.cgi?id=233169
Summary [WebGPU] Fix namespace comments
Myles C. Maxfield
Reported 2021-11-15 21:50:33 PST
[WebGPU] Fix namespace comments
Attachments
Patch (101.56 KB, patch)
2021-11-15 21:51 PST, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (101.59 KB, patch)
2021-11-15 21:51 PST, Myles C. Maxfield 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2021-11-15 21:51:06 PST
Created attachment 444344 [details] Patch
Myles C. Maxfield
Comment 2 2021-11-15 21:51:39 PST
Created attachment 444345 [details] Patch
Alex Christensen
Comment 3 2021-11-15 23:00:07 PST
Comment on attachment 444345 [details] Patch Sure. Why is WebGPU inside namespace PAL at all?
Alex Christensen
Comment 4 2021-11-16 07:41:55 PST
Comment on attachment 444345 [details] Patch You may consider using C++17 nested namespace syntax to completely remove this instead. namespace PAL::WebGPU { ... } // namespace PAL::WebGPU
Myles C. Maxfield
Comment 5 2021-11-16 09:48:59 PST
(In reply to Alex Christensen from comment #3) > Comment on attachment 444345 [details] > Patch > > Sure. > Why is WebGPU inside namespace PAL at all? This part of the WebGPU implementation is in pal/graphics/WebGPU, so I assumed that means it should get the PAL namespace. The parts that are in WebGPU.framework won't use the PAL namespace.
Myles C. Maxfield
Comment 6 2021-11-16 12:24:46 PST
Committed r285879 (244305@main): <https://commits.webkit.org/244305@main>
Radar WebKit Bug Importer
Comment 7 2021-11-16 12:25:21 PST
<rdar://problem/85469938>
Note You need to log in before you can comment on or make changes to this bug.